Remove existing tests. #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed tests are broken with reecent versions of tornado and webtest, but broken tests must be fixed, not removed! And why killing the flake8 test from tox? |
| @@ -1,11 +1,8 @@ | |||
| [tox] | |||
| envlist = py26,py27,py34,flake8 | |||
| envlist = py26,py27,py34 | |||
There was a problem hiding this comment.
Why did you remove flake8 ???
|
Natim wanted them axed: #60 I've removed flake8 as it failed (on a Py3.4 env): |
|
@douardda current tests are not for the tornado version but for the previous bottled version they aren't running in travis at the moment. |
|
@riklaunim We should keep flake8, tox is running it from python27 |
|
ok, one moment ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.