Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow plugins to have [env:name] and find plugins relatively based on… #1016

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Allow plugins to have [env:name] and find plugins relatively based on… #1016

wants to merge 10 commits into from

Conversation

pconerly
Copy link
Contributor

… env's PYTHONPATH

let's see about those tests...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 63.027% when pulling 7b20a3f on pconerly:relative-plugin into 6161a43 on circus-tent:master.

@pconerly pconerly closed this Nov 12, 2016
@pconerly pconerly reopened this Nov 12, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 62.995% when pulling 7b20a3f on pconerly:relative-plugin into 6161a43 on circus-tent:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 63.027% when pulling 9879cb6 on pconerly:relative-plugin into 6161a43 on circus-tent:master.

pconerly
pconerly commented Nov 16, 2016
View reviewed changes
circus/tests/test_reloadconfig.py
@@ -168,5 +168,6 @@ def test_reload_ignorearbiterwatchers(self):
statsd = a.get_watcher('circusd-stats')
yield a.reload_from_config(_CONF['reload_statsd'])
self.assertEqual(statsd, a.get_watcher('circusd-stats'))
yield self._tear_down_arbiter(a)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think actually fixed the tests, but I think that it did help stop having dangling plugin processes (as in #1017 (comment) )

@pconerly
Copy link
Contributor Author

pconerly commented Nov 16, 2016 •
edited
Loading

@k4nar tests pass, code review is much appreciated :)

Two hypothesises in regards to the tests:

  1. I needed to call os.close(fd) when I was creating temporary files (but this shouldn't cause the current master to fail)
  2. Travis gets hammered on saturdays and errors out?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 63.027% when pulling dd8d0ec on pconerly:relative-plugin into 6161a43 on circus-tent:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pconerly @coveralls