Fix:1212 Util.py/load_virtualenv picks incorrect python version if py_ver=None #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cks only major and minor values and misses out on micro. It errors out determine_sitedir() for a non-existent dir. Fix should certainly solve that.
|
This one looks good to me. I hope this change is backwards compatible with all the existing installations of the package. Can you please fix the formatting of the commit message? You have |
…im py_ver in case user supplies complete version
Hi Ivan, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If py_ver is None, load_virtualenv picks only major and minor values and misses out on micro. It errors out determine_sitedir() for a non-existent dir. Fix should certainly solve that.