python3 fixes #963
python3 fixes #963
Conversation
|
I have no idea why tests, that, as I can see, have no connection to my changes failed now... |
|
Our CI is in a very bad shape, sorry about that :( . I don't have much time right now to fix it. |
|
k4nar, thanks for answer. Should I return feature, about not discover watchdog itself in code? |
Sorry, I'm not sure to understand what you mean. |
| that cause exception. | ||
| Probably this can be done better, | ||
| that just decode data""" | ||
| result = re.match(self.msg_regex, data.decode()) |
There was a problem hiding this comment.
It makes perfect sense, I think you can even remove your comment (the method is already named decode_received_udp_message ;) .
|
k4nar, I mean, that when we run watchdog from config, as plugin, watchdog kills himself, since it doesn't receives hearthbeat messages. I will fix comment and remove comment from decode tomorrow. |
|
@kyudin : I've (mostly) fixed our test suite, could you try to rebase your branch with the latest version of master? |
|
Are these changes still needed? |
There are some problems with watchdog plugin under python3 and here is one variant of fixes.