Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make MKI a stream level setting #690

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Commits on Feb 1, 2024

  1. make MKI a stream level setting

    Move "use_mki" from a per packet parameter to a stream wide value.
    When using MKI all master keys need to have a valid MKI id.
    
    Merge the MKI protect & unprotect functions. The MKI index is currently still
    passed per packet, this could also be moved up to stream level with a
    srtp_set_mki(ssrc) api as this is not likely to change per packet.
    pabuhler committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    120b51b View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. move mki_size to the stream level

    RFC 3711 section-3.2.1 states that the use of MKI and the size of
    the MKI id must be fixed for the life time of stream. By moving
    the mki_size value along with mki_use value to the stream level
    allows this to be enforced for all keys.
    Added a unit test to verify it can not be changed via an update.
    pabuhler committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d1afbb0 View commit details
    Browse the repository at this point in the history