Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a not in-place api's for protect/unprtect #693

Merged
merged 8 commits into from
Jun 12, 2024

Commits on May 6, 2024

  1. Configuration menu
    Copy the full SHA
    4b84591 View commit details
    Browse the repository at this point in the history
  2. introduce not-in-place io api

    A layer to the srtp driver test is added to be able to run the tests both in-place & not-in-place without duplicating the test.
    
    The not-in-place functions are currently a minimal implementation using a memcpy.
    pabuhler committed May 6, 2024
    Configuration menu
    Copy the full SHA
    8c13ee8 View commit details
    Browse the repository at this point in the history
  3. implement not in-place api's for protect/unprotect

    The protect/unprotect api's can now operate both in-place or not in-place, depending on the requirements of the caller.
    The length of the out buffer can now be checked to ensure there is sufficient space.
    
    Tests are add to verify validation of the output buffer length.
    pabuhler committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7bb4e3a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    00b888d View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Update api documentation for not in-place io

    Also update the minimal code example in README.md to reflect the new
    api.
    pabuhler committed May 23, 2024
    Configuration menu
    Copy the full SHA
    0a0dff6 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Configuration menu
    Copy the full SHA
    327bdc2 View commit details
    Browse the repository at this point in the history
  2. remove unnecessary assumption about the size of dst

    With the new api the full length of dst is now passed in, if it is too small it should fail.
    pabuhler committed May 26, 2024
    Configuration menu
    Copy the full SHA
    01b8704 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. explicitly check dst len is >= tag size

    This is a safety check to ensure we do not wrap dst len when removing tag size.
    All of this code would get much cleaner if the tag could just be returned instead of cached. see cisco#714
    pabuhler committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    703f2e9 View commit details
    Browse the repository at this point in the history