Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIC-1502] Updated Group Filters with short-term fix for mobile style. #1173

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

alan-cole
Copy link
Collaborator

@alan-cole alan-cole commented Dec 15, 2023

https://salsadigital.atlassian.net/browse/CIVIC-1502

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [CS-123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Updated Group Filters with short-term fix for mobile style. This style was taken and modified from another civictheme project.

Screenshots

no-sidebar.mp4
with-sidebar.mp4

@alan-cole alan-cole added the State: Needs review Pull requests needs a review from assigned developers label Dec 15, 2023
@AlexSkrypnyk AlexSkrypnyk merged commit 9c3a0b7 into develop Dec 15, 2023
10 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/CIVIC-1502-group-filter-mobile-fix branch December 15, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Needs review Pull requests needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants