Issue #3476600: Adding a layout setting for controlling space around the layout. #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-cole
added
the
State: Needs review
richardgaunt
changed the title
|
@alan-cole I pushed a change moving the setting out of the layout (and fixing prior issue) into a preprocess so we only have templates variables exposed in the template. |
|
Thanks @richardgaunt - I've updated this as per our discussion to include an 'auto' option for the default "sidebars = top spacing" logic. |
Rather than vertical spacing 'none' provide the logic that sidebars will add a top space; an 'auto' implementation has been added that will automatically assign padding based on spaces. This allows the 'none' option to explicitly set no spacing, as would be expected if choosing a 'none' option.
alan-cole
force-pushed
the
feature/page-layout-3-col-vertical-spacing
branch
from
1b3ae9a
to
da83700
Compare
alan-cole
changed the title
richardgaunt
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.drupal.org/project/civictheme/issues/3476600
Checklist before requesting a review
Issue #123456 by drupal_org_username: Issue titleChangedsection about WHY something was done if this was not a normal implementationChanged
Screenshots