Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3460512 by joshua1234511, richardgaunt, fionamorrison23, alexskrypnyk, alancole: Add ellipsis to truncated card summary. #1307

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Oct 2, 2024

https://www.drupal.org/project/civictheme/issues/3460512

Checklist before requesting a review

  • I have formatted the subject to include ticket number as Issue #123456 by drupal_org_username: Issue title
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Included an ellipsis when truncating.

Screenshots

@joshua-salsadigital joshua-salsadigital added the State: Needs review Pull requests needs a review from assigned developers label Oct 2, 2024
@joshua-salsadigital joshua-salsadigital self-assigned this Oct 2, 2024
Copy link
Collaborator

@richardgaunt richardgaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joshua-salsadigital for porting.

@alan-cole Thanks for the work.

@richardgaunt richardgaunt merged commit 4723b06 into develop Oct 2, 2024
13 checks passed
@richardgaunt richardgaunt deleted the feature/3460512-ellipsis-summary branch October 2, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Needs review Pull requests needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants