Fixed multiple checkboxes mistakenly marked as required if a Field is marked as required. #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… marked as required.
richardgaunt
added
the
State: Needs review
richardgaunt
reviewed
Oct 6, 2024
| @@ -191,6 +191,8 @@ function civictheme_preprocess_fieldset__form_element__civictheme_field__checkbo | |||
| 'id' => Html::cleanCssIdentifier($element['#id'] . '-' . $value), | |||
| 'is_checked' => is_array($element['#default_value']) ? in_array($value, $element['#default_value']) : $element['#default_value'] == $value, | |||
| 'is_disabled' => isset($element['#attributes']['disabled']), | |||
| // Checkboxes controls with a group cannot be required by definition. | |||
| 'is_required' => FALSE, | |||
There was a problem hiding this comment.
@AlexSkrypnyk If I am understanding you, you are saying you shouldn't compel a user to check all the checkboxes.
There was a problem hiding this comment.
I’m saying that currently all of the checkboxes are marked required if the field has required attribute. But that required attribute means “at least one checkbox” is required rather than “all checkboxes are required”. Of course, this is in the context of “checkboxes” element only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs UIKit change to be merged civictheme/uikit#405
Use case: webform field with multiple checkboxes marked as required makes all checkboxes required.