Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update box matrix normalization and decouple K matrix model from BoxQuantization #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Apr 18, 2018

  1. Add build option for shared library.

    Ben Horz committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    35dff2f View commit details
    Browse the repository at this point in the history
  2. Decouple K matrix parametrization from BoxQuantization.

    Previously the K matrix model was intertwined with the BoxQuantizationclass,
    e.g. fit parameters were accessed through BoxQuantization. Instead, the
    BoxQuantization class should not care about how a K Matrix model is
    implemented as long as it provides the two functions
    
    	calculate(..)
    	isZero(..)
    
    now defined pure virtual in the new KtildeMatrixBase base class. A
    K-matrix model is implemented by subclassing KtildeMatrixBase and
    providing these functions. Model parameters are handled exclusively by
    the K matrix model provided by the user.
    
    A BoxQuantization object is now constructed by passing in an object
    derived from KtildeMatrixBase and a boolean indicating whether this is a
    model for Ktilde or KtildeInverse.
    
    The example driver routines have been updated to reflect the changes in
    interface.
    Ben Horz committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    de71b57 View commit details
    Browse the repository at this point in the history
  3. Change normalization of box matrix elements.

    This change in normalization induces a change in the normalization of
    the Ktilde matrix to make it more natural. The difference is most easily
    seen by comparing
    
    	eq. (2.9) of https://arxiv.org/abs/1802.03100v1	(new convention)
    	eq. (46)  of https://arxiv.org/abs/1707.05817v1 (old convention)
    
    In the old normalization, the K matrix depended on m_ref L, i.e. a
    finite-volume quantity. Using the new normalization, the K matrix does
    not pick up a dependence on any finite-volume quantity, and the
    Breit-Wigner parametrization takes its canonical form.
    Ben Horz committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    f5f372f View commit details
    Browse the repository at this point in the history
  4. Add health warning to README about normalization.

    Ben Horz committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    e20515c View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Configuration menu
    Copy the full SHA
    70988be View commit details
    Browse the repository at this point in the history