Fix supervisor conf file owners #91
Merged
+49
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although supervisor has been removed from 2.11 onwards, it is still used in the 2.10 and 2.9 images. In #80 the supervisord.conf [was modified][1] to run the process as the newly created `ckan-sys` user, but this same conf file is used in the alpine image, where this user does not exist. Conversely, the 2.9 Python image includes the same file as the alpine one, so it doesn't use the new user. This PR splits the files in two different versions so they use the appropiate user. [1] https://github.com/ckan/ckan-docker-base/pull/80/files#diff-a9f3dc77dfb98b40d119163f7a8049572695f238c20380a6c9ca8e43c4a9daf3R4
kowh-ai
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although supervisor has been removed from 2.11 onward, it is still used in the 2.10 and 2.9 images. In #80 the supervisord.conf was modified to run the process as the newly created
ckan-sysuser, but this same conf file is used in the alpine image, where this user does not exist. Conversely, the 2.9 Python image includes the same file as the alpine one, so it doesn't use the new user.This PR splits the files in two different versions so they use the appropriate user.