Skip to content

Commit

Permalink
Handle more tidy messages
Browse files Browse the repository at this point in the history
  • Loading branch information
ckormanyos committed Oct 11, 2024
1 parent 9fab68b commit e5f2fb0
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 10 deletions.
10 changes: 8 additions & 2 deletions ref_app/src/mcal/host/mcal_wdg.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,15 @@
{
template<typename unsigned_tick_type>
class timer;
}
} // namespace util

namespace sys { namespace idle { void task_func(); } }
namespace sys
{
namespace idle
{
void task_func();
} // namespace idle
} // namespace sys

namespace mcal
{
Expand Down
2 changes: 1 addition & 1 deletion ref_app/src/util/STL/impl/cmath_impl_gamma.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ float tgammaf(float x)
}

// Return (and possibly reflect) the result.
if(false == b_neg)
if(!b_neg)
{
return gamma_value;
}
Expand Down
8 changes: 4 additions & 4 deletions ref_app/src/util/utility/util_communication.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
~communication_buffer_depth_one_byte() override = default;

protected:
buffer_type recv_buffer { };
buffer_type recv_buffer { }; // NOLINT(cppcoreguidelines-non-private-member-variables-in-classes,misc-non-private-member-variables-in-classes)

communication_buffer_depth_one_byte() = default;

Expand All @@ -82,9 +82,11 @@
static constexpr std::size_t channel_count = ChannelCount;

public:
communication_multi_channel() = delete;

explicit communication_multi_channel(communication_base** p_com_channels)
{
std::copy(p_com_channels, p_com_channels + channel_count, my_com_channels.begin());
std::copy(p_com_channels, p_com_channels + channel_count, my_com_channels.begin()); // NOLINT(cppcoreguidelines-pro-bounds-pointer-arithmetic)
}

~communication_multi_channel() override = default;
Expand Down Expand Up @@ -118,8 +120,6 @@
std::array<communication_base*, channel_count> my_com_channels { }; // NOLINT(readability-identifier-naming)
std::size_t my_index { }; // NOLINT(readability-identifier-naming)

communication_multi_channel() = delete;

static_assert(channel_count > 0U, "Error channel_count must be greater than zero.");
};
} // namespace util
Expand Down
6 changes: 3 additions & 3 deletions ref_app/src/util/utility/util_time.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
static constexpr auto timer_mask =
static_cast<unsigned_tick_type>
(
(UINTMAX_C(1) << (std::numeric_limits<unsigned_tick_type>::digits - 1)) - UINTMAX_C(1)
(UINTMAX_C(1) << static_cast<unsigned>(std::numeric_limits<unsigned_tick_type>::digits - 1)) - UINTMAX_C(1)
);

public:
Expand All @@ -39,7 +39,7 @@

constexpr timer() = default;

constexpr timer(tick_type tick_value) : my_tick(my_now() + tick_value) { }
explicit constexpr timer(tick_type tick_value) : my_tick(my_now() + tick_value) { }

constexpr timer(const timer& other) = default;

Expand Down Expand Up @@ -90,7 +90,7 @@
{
const timer t_delay(delay);

while(false == t_delay.timeout())
while(!t_delay.timeout())
{
mcal::wdg::secure::trigger();
}
Expand Down

0 comments on commit e5f2fb0

Please sign in to comment.