-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#89 --- RFB gold processing #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- gold file(s) isn't compliant to the repository cataloging guideline (https://github.com/clamsproject/aapb-annotations?tab=readme-ov-file#gold-dataset-files) must be in
golds
dir, separate by asset guid. Please read through the guidelines and associated documents (conventions and templates) - gold file is using
CR LF
, but we use linux format (LF
only) - the sub-project readme also needs to be updated based on the proc.py and gold format.
For the second discussion point, I think we should keep the duplicate labels, since they are also human generated (valuable) data that have potential usages. |
Implementations
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, output looks good. Just a few minor thing
- old
csv
gold file now can be deleted - requirements.txt seems to be too verbose, while there's only one thrid-party library (
clams-utils
) used in the proc.py..?
In fact, I just exported |
@bohJiang12 I added a new column to mark the scene types on which the annotation is done. Not sure if and how adding this new column affects the evaluation counter-part (clamsproject/aapb-evaluations#66). Please take a look at this change. |
This PR is to add a
process.py
file for converting a directory of gold JSON annotations into a single CSV file. This satisfies the first two objectives of #89.additions
role-filler-binding/process.py
process.py
on231117-aapb-annotations-44
datadiscussion before merging