Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Issue #5 and Resolve Issue #6 #8

Merged
merged 20 commits into from
Oct 18, 2020
Merged

Conversation

terrelsa13
Copy link
Contributor

@terrelsa13 terrelsa13 commented Sep 21, 2020

Resolve issues #5 ad #6.
All embys/jellyfins may not report the same media item data back. Update to handle missing data items from emby/jellyfin used to build detailed output.
Now if any of the extra data used to build detailed output is missing; fall back to the basic data needed to delete the episode and continue on to the next media item.
Add server branding option, choose emby or jellyfin.
Add base url for jellyfin so API calls work when base url is changed.
Update get_days_since_last_watched() to work with emby and jellyfin.
Text clean-up.

All embys may not report the same media item data back. Update to handle missing data items from emby. Script uses this data to build detailed output about what is watched and what will and will not be deleted.
Now if any of the extra data is missing we fall back to the basic data needed to delete the episode and continue on to the next media item.
…ption

Handle KeyError Exception Gracefully
Add server branding config option
Text clean up
Add to choose emby or jellyfin
Add base url for jellyfin so API calls work when base url is changed
Update get_days_since_last_watched() to work with emby and jellyfin (hopefully)
Text clean-up
All embys/jellyfins may not report the same media item data back. Update to handle missing data items from emby/jellyfin used to build detailed output.
Now if any of the extra data used to build detailed output is missing; fall back to the basic data needed to delete the episode and continue on to the next media item.
Handle KeyError Exception Gracefully.
Add server branding option, choose emby or jellyfin.
Add base url for jellyfin so API calls work when base url is changed.
Update get_days_since_last_watched() to work with emby and jellyfin.
Text clean-up.
@terrelsa13 terrelsa13 closed this Sep 21, 2020
@terrelsa13 terrelsa13 reopened this Sep 21, 2020
Keep episode if the season or series the episode is under is marked as favourite.
Rename "ignore_favorites_*" to "keep_favorites_*" (recommend creating new config file, else will assume user does not want to delete favourites)
Updates to formatting
Put the isfav updates into functions to keep get_items() clean-ish
Fix bug with overwriting the original contents of the debug file when looking for favourite seasons and series.
Similar media will be grouped together in the output making it easier to read.
   Media is now processed in the following order:
      -By Type
      -Series Name (if episode)
      -Season Number (if episode)
      -Episode Number (if episode)
      -Name (if not episode)
Update to readme to say http://localhost:8096/emby instead of http://server:8096/emby
Update to state hashed password is stored.
Plaintext password is not stored.
Update to state hashed password stored
Update to state hashed password stored
Spelling
@clara-j clara-j merged commit b284e85 into clara-j:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants