Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icons? #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New icons? #42

wants to merge 1 commit into from

Conversation

tonsky
Copy link

@tonsky tonsky commented Nov 19, 2024

I love using clj-async-profiler, but one thing I noticed is that icons are confusing to me. ↙↗ reads like “fullscreen” and 🔄 reads like “reload”. I drew new ones, but if you don’t like them we can discuss how you’d want them to look. Let me know!

Screenshot 2024-11-19 at 15 16 31
Screenshot 2024-11-19 at 15 16 35

@alexander-yakushev
Copy link
Member

alexander-yakushev commented Nov 19, 2024

Thank you for tackling this! The current icons are just some random stuff from the web. I've tried to make them match one another, but I don't have a strong attachment to them. Your icons are 100% nicer to look at but I'd like to clarify some points about the UX part.

The current arrows for collapse/expand sidebar don't bother me much. Being diagonal they also have a nice property of hinting that the action will change the size both horizontally and vertically which is indeed what happens. It's by no means obligatory; just a small pleasing detail. What I dislike about them is that they are too "anemic" when compared to other icons. Your icons, on the other hand, are better because they have a clear outline that matches the others well. I also really appreciate that your icons have arrows too. For example, I to this day can't quckly recognize what Github's "Collapse sidebar" button does, like, what the hell:
image
Is there a reason why expand has a vertical divider and collapse does not? I see that Github's interface has similar buttons for collapse/expand and they both have the dividers.

For your reversal icons, I really really like how they look. It is incredibly witty way to put this very recognizable state of the flamegraph into a minimalistic icon. The only thing I'm afraid of is that while they represent the current state perfectly, as a button they don't compel me as a user to click them because the first time I'm not sure what happens when I do. Sure, the button is accompanied by both a label and a tooltip, so it's not a big deal. And you are right that the current icon can be confused with "refresh" so it doesn't accurately tell the user what happens either.

.toggle:hover {background-color: #e6f2ff; border-radius: 5px;}
.toggle.arcs:hover svg {fill:#e6f2ff;}
.toggle:active {transform:scale(0.90);}
.toggle.toggled {background-color: #006d5b; border-radius: 5px;}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "pressed in" effect is also used for "Highlight" – do you want to eliminate it there too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants