Merge pull request #51 from clouddrove/fix/issue-233-a

fix: Fixed example folder variables.
clouddrove · Aug 3, 2023 · 77f2e48 · 77f2e48
2 parents 4ff01fc + cd063d1
commit 77f2e48
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 8 deletions.
diff --git a/_example/basic/example.tf b/_example/basic/example.tf
@@ -1,3 +1,8 @@
+locals {
+  name        = "app"
+  environment = "test"
+}
+
 ##----------------------------------------------------------------------------- 
 ## Subnet Module Call. 
 ## Both private and public subnet will be deployed.     
@@ -6,13 +11,13 @@
 #tfsec:ignore:aws-ec2-no-public-ingress-acl
 module "subnets" {
   source              = "./../../"
-  name                = "subnets"
-  environment         = "test"
+  name                = local.name
+  environment         = local.environment
   nat_gateway_enabled = true
   availability_zones  = ["eu-west-1a", "eu-west-1b", "eu-west-1c"]
-  vpc_id              = "vpv_id-------"
+  vpc_id              = "vpv_id-xxxxxxx"
   type                = "public-private"
-  igw_id              = "vpc_igw_id---"
+  igw_id              = "vpc_igw_id-xxxxxxx"
   cidr_block          = "10.0.0.0/16"
   enable_ipv6         = false
 }
diff --git a/_example/complete/example.tf b/_example/complete/example.tf
@@ -34,7 +34,6 @@ module "subnets" {
   source                                         = "./../../"
   name                                           = local.name
   environment                                    = local.environment
-  label_order                                    = ["name", "environment"]
   nat_gateway_enabled                            = true
   availability_zones                             = ["eu-west-1a", "eu-west-1b", "eu-west-1c"]
   vpc_id                                         = module.vpc.vpc_id

diff --git a/_example/private-subnet/example.tf b/_example/private-subnet/example.tf
@@ -40,5 +40,5 @@ module "private-subnets" {
   type                = "private"
   cidr_block          = module.vpc.vpc_cidr_block
   ipv6_cidr_block     = module.vpc.ipv6_cidr_block
-  public_subnet_ids   = ["subnet-xxxxxxxxxxxx", "subnet-xxxxxxxxxxxx"]
+  public_subnet_ids   = ["subnet-xxxxxxx", "subnet-xxxxxxx"]
 }
diff --git a/_example/public-private-subnet-single-nat-gateway/example.tf b/_example/public-private-subnet-single-nat-gateway/example.tf
@@ -36,7 +36,6 @@ module "subnets" {
   single_nat_gateway  = true
   name                = local.name
   environment         = local.environment
-  label_order         = ["name", "environment"]
   availability_zones  = ["eu-west-1a", "eu-west-1b", "eu-west-1c"]
   vpc_id              = module.vpc.vpc_id
   type                = "public-private"

diff --git a/_example/public-subnet/example.tf b/_example/public-subnet/example.tf
@@ -33,7 +33,6 @@ module "subnets" {
   source             = "./../../"
   name               = local.name
   environment        = local.environment
-  label_order        = ["name", "environment"]
   availability_zones = ["us-east-1a", "us-east-1b", "us-east-1c"]
   vpc_id             = module.vpc.vpc_id
   type               = "public"