Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added support for additional tags for private and public subnet #53

Closed
wants to merge 6 commits into from
Closed

feat: Added support for additional tags for private and public subnet #53

wants to merge 6 commits into from

Conversation

13archit
Copy link
Member

@13archit 13archit commented Sep 11, 2023 •
edited
Loading

what

  • Added support for additional tags for private and public subnet

why

  • To provide extra tags as per requirement.

@13archit 13archit requested review from a team and h1manshu98 September 11, 2023 10:12
@clouddrove-ci clouddrove-ci self-assigned this Sep 11, 2023
@13archit 13archit assigned 13archit and unassigned clouddrove-ci Sep 11, 2023
@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output 



      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          





      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          

  
  

  
      @13archit
  13archit


        marked this pull request as draft

    
      September 11, 2023 14:40
    
    




  

  
  

  
      @13archit
  13archit


        marked this pull request as draft

    
      September 11, 2023 14:40
    
    




    

    

      
    

    


      

          @13archit
13archit




            closed this


      Sep 12, 2023

    

  


    







      

  
      



  

  @13archit





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  Author


  


  

    

  





      


        


  
    

      
          
Will create new PR for this.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  
  

  
      @13archit
  13archit


    
    deleted the
    
      
        feat/extra_tags
    
    branch

    
      September 12, 2023 08:42
    
    













  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    

    
  

    Reviewers
  


    


      

          

  
    @anmolnagpal
  
    anmolnagpal


                Awaiting requested review from anmolnagpal

                    anmolnagpal is a code owner

        
      

      

          

  
    @clouddrove-ci
  
    clouddrove-ci


                Awaiting requested review from clouddrove-ci

                    clouddrove-ci is a code owner

        
      

      

          

  
    @h1manshu98
  
    h1manshu98


                Awaiting requested review from h1manshu98


        
      

      

          

  
    @d4kverma
  
    d4kverma


                Awaiting requested review from d4kverma


        
      

      

          

  
    @themaniskshah
  
    themaniskshah


                Awaiting requested review from themaniskshah


        
      

      

          

  
    @nikitadugar
  
    nikitadugar


                Awaiting requested review from nikitadugar


        
      


      






    

  


      
  

    Assignees
  



        

      

        

  
    @13archit
  
    13archit
    

      








      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




        
      

    

  
      

  

    

      2 participants
    

    

        
          @13archit 
        
          @clouddrove-ci