Upgrade dependencies, including http and hyper, where possible. #233

ozabalaferrera · 2024-07-28T03:18:38Z

Description

This PR is the result of the discussion in #227. It upgrades various dependencies, including http and hyper, to the latest versions.

Status

This PR is ready for review. I worked on this sporadically, so I am sure there are better ways to accomplish some of what I did here.

Excluded

warp and actix have not been upgraded to http v1; I found it difficult to convert between types or implement traits. Therefore, those bindings here are mostly unchanged. I also created a separate feature flag for the old http v0.2.

Testing

I ran all the commands on the contributing guide. I also ran cargo test --all --features with all the features individually.

Breaks docs. Signed-off-by: Omar Zabala-Ferrera <73452461+ozabalaferrera@users.noreply.github.com>

ozabalaferrera · 2024-08-07T21:44:45Z

@jcrossley3 or @Lazzaretti would you be able to review this?

ozabalaferrera · 2024-08-08T22:15:53Z

I forgot about the example projects and other archs 🤦‍♂️. I'll work on fixing these.

ozabalaferrera · 2024-08-19T22:58:32Z

I could use some help with the failing tests. I'm not sure what is causing this error:

It happens when running the test:

cargo test --target wasm32-wasi --features "http-0-2-binding hyper-0-14 hyper_wasi"

But the below works, so I imagine some testing dependency is the issue.

cargo build --target wasm32-wasi --features "http-0-2-binding hyper-0-14 hyper_wasi"

I'm not really sure if that is indicative of a real error, especially since building the example works:

cd example-projects/wasi-example/
cargo build --target wasm32-wasi

That being said, running causes an error, but I think it is due to my environment.

cd example-projects/wasi-example/
cargo run --target wasm32-wasi

target/wasm32-wasi/debug/wasi-example.wasm: 1: : not found
target/wasm32-wasi/debug/wasi-example.wasm: 1: : not found
target/wasm32-wasi/debug/wasi-example.wasm: 1: : not found
target/wasm32-wasi/debug/wasi-example.wasm: 1: : not found
target/wasm32-wasi/debug/wasi-example.wasm: 1: ~: not found
target/wasm32-wasi/debug/wasi-example.wasm: 1: : not found

I've not worked with wasm, so any help would be appreciated.

sophokles73 · 2024-09-27T11:43:16Z

@ozabalaferrera the problem seems to be that the updated Mockito crate pulls in tokio (which the original version did not).

I am able to build and test for the wasm32-wasi target when I use Cargot.toml

...
mockito = "0.31.1"
...

I have then installed wasmedge (https://wasmedge.org/) and then run the tests successfully using

CARGO_TARGET_WASM32_WASI_RUNNER=wasmedge cargo test --target wasm32-wasi

ozabalaferrera · 2024-09-28T01:25:57Z

Thanks, @sophokles73 ! I've been pretty busy, but took a minute to apply your fix. It looks like all tests are passing now.
@jcrossley3 or @Lazzaretti, sorry for the delay. Could you take another look at this and let me know if there is anything else I should address?

sophokles73 · 2024-10-02T07:01:10Z

@jcrossley3 @Lazzaretti any chance you'll find the time to take a look?

jcrossley3

This is a lot of work, thanks!

jcrossley3 · 2024-11-01T15:54:21Z

example-projects/axum-example/src/main.rs

+        unsafe {
+            std::env::set_var("RUST_LOG", "axum_example=debug,tower_http=debug")
+        }


Why is the unsafe needed here? Just curious.

I vaguely remember it was needed because set_var is unsafe now. But I removed it and it seems fine. Not sure what happened before 🤷 ... I pushed a commit removing the two uses of unsafe.

I forgot to sign off the commit, so I had to overwrite that commit history to fix it.
Let me know if you'd like me to squash or clean things up in any other way.

The pipeline still has a problem because of the signoff.

Lazzaretti

Thanks a lot for the PR, and sorry for the late review!

Lazzaretti · 2024-11-03T09:02:57Z

src/binding/poem/extractor.rs

+// ^ this is causing weird lifetime issues:
+//
+// lifetime parameters or bounds on method `from_request` do not match the trait declaration
+// lifetimes do not match method in trait


Can you elaborate a bit on this?

It gives the following error:

error[E0195]: lifetime parameters or bounds on method `from_request` do not match the trait declaration --> src\binding\poem\extractor.rs:17:14 | 17 | async fn from_request(req: &'a Request, body: &mut RequestBody) -> Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lifetimes do not match method in trait

I believe because #[async_trait] is not applied to poem's FromRequest trait.
The version of poem used previously did apply it here: https://github.com/poem-web/poem/blob/v1.2.34/poem/src/web/mod.rs#L272
I didn't find the exact version where it changed, but it is gone now: https://github.com/poem-web/poem/blob/master/poem/src/web/mod.rs#L310

Let me know if you'd like me to remove the comments and or leave a better explanation.

@jcrossley3 what do you think about this?

I don't recall who contributed the poem impl, but if the poem version we're depending on doesn't need it, I think it's safe to omit it without any comment.

Totally agree. @ozabalaferrera can you then please remove the comment?

@Lazzaretti, I removed the comment and rebased to fix the sign-off. Let me know if there is anything else I should address.

delegate-attr, base64, snafu, bitflags, hostname, and serde_yaml. Signed-off-by: Omar Zabala-Ferrera <73452461+ozabalaferrera@users.noreply.github.com>

ozabalaferrera · 2024-11-07T23:01:52Z

@sophokles73 do you happen to know what this is about:
https://github.com/cloudevents/sdk-rust/actions/runs/11712115261/job/32666055306?pr=233#step:8:33

error: toolchain 'nightly-x86_64-unknown-linux-gnu' does not support target 'wasm32-wasi'; did you mean 'wasm32-wasip1'?

I didn't even know wasm32-wasip1 existed!
Everything seemed to work on my repo just a bit ago: https://github.com/ozabalaferrera/cloudevents-sdk-rust/actions/runs/11712114968

EDIT:

Ah, looks like we maybe hit the 2024-10-17 deadline here: https://blog.rust-lang.org/2024/04/09/updates-to-rusts-wasi-targets.html
Though I am not sure why it worked last night 🤷

I changed the target in the workflow. This should be ready for another test run, @Lazzaretti or @jcrossley3. Sorry for the back and forth!

Signed-off-by: Omar Zabala-Ferrera <73452461+ozabalaferrera@users.noreply.github.com>

Upgrade axum.

03021f7

Breaks docs. Signed-off-by: Omar Zabala-Ferrera <73452461+ozabalaferrera@users.noreply.github.com>

sophokles73 mentioned this pull request Sep 27, 2024

Support mapping between UMessage and cloudevents eclipse-uprotocol/up-rust#204

Draft

ozabalaferrera force-pushed the oz_upgrade_all branch from 403bffb to bf18f7c Compare September 28, 2024 01:11

jcrossley3 approved these changes Nov 1, 2024

View reviewed changes

ozabalaferrera force-pushed the oz_upgrade_all branch from c195938 to 1718174 Compare November 1, 2024 22:38

Lazzaretti reviewed Nov 3, 2024

View reviewed changes

Upgrade several dependencies.

e8f71dc

delegate-attr, base64, snafu, bitflags, hostname, and serde_yaml. Signed-off-by: Omar Zabala-Ferrera <73452461+ozabalaferrera@users.noreply.github.com>

ozabalaferrera force-pushed the oz_upgrade_all branch from d07a024 to e8f71dc Compare November 6, 2024 21:23

Change target wasm32-wasi to wasm32-wasip1.

b545fbc

Signed-off-by: Omar Zabala-Ferrera <73452461+ozabalaferrera@users.noreply.github.com>

ozabalaferrera requested a review from Lazzaretti November 8, 2024 22:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade dependencies, including http and hyper, where possible. #233

Upgrade dependencies, including http and hyper, where possible. #233

ozabalaferrera commented Jul 28, 2024

ozabalaferrera commented Aug 7, 2024

ozabalaferrera commented Aug 8, 2024

ozabalaferrera commented Aug 19, 2024

sophokles73 commented Sep 27, 2024

ozabalaferrera commented Sep 28, 2024

sophokles73 commented Oct 2, 2024

jcrossley3 left a comment

jcrossley3 Nov 1, 2024

ozabalaferrera Nov 1, 2024

ozabalaferrera Nov 1, 2024

Lazzaretti Nov 6, 2024

Lazzaretti left a comment

Lazzaretti Nov 3, 2024

ozabalaferrera Nov 3, 2024 •

edited

Loading

Lazzaretti Nov 6, 2024

jcrossley3 Nov 6, 2024

Lazzaretti Nov 6, 2024

ozabalaferrera Nov 6, 2024

ozabalaferrera commented Nov 7, 2024 •

edited

Loading

Upgrade dependencies, including http and hyper, where possible. #233

Are you sure you want to change the base?

Upgrade dependencies, including http and hyper, where possible. #233

Conversation

ozabalaferrera commented Jul 28, 2024

Description

Status

Excluded

Testing

ozabalaferrera commented Aug 7, 2024

ozabalaferrera commented Aug 8, 2024

ozabalaferrera commented Aug 19, 2024

sophokles73 commented Sep 27, 2024

ozabalaferrera commented Sep 28, 2024

sophokles73 commented Oct 2, 2024

jcrossley3 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Lazzaretti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ozabalaferrera Nov 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ozabalaferrera commented Nov 7, 2024 • edited Loading

ozabalaferrera Nov 3, 2024 •

edited

Loading

ozabalaferrera commented Nov 7, 2024 •

edited

Loading