[build] Disable WebGPU for Windows non-release builds #2988
+45
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
force-pushed
the
felix/102324-windows-no-webgpu
branch
from
997bf14
to
7ec4270
Compare
|
This does not seem to be as impactful as expected – will take some more work |
fhanau
force-pushed
the
felix/102324-windows-no-webgpu
branch
4 times, most recently
from
9683707
to
feab6aa
Compare
fhanau
force-pushed
the
felix/102324-windows-no-webgpu
branch
5 times, most recently
from
eae12ea
to
13c0d0b
Compare
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds. Based on profiling on #2981, this is caused by the repo mapping stage for dawn taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected. Fetching WPT also contributes here. Only fetch/use WPT on Unix and only configure targets based on globs as we start using them, Bazel configures 90,000 targets for it otherwise.
fhanau
force-pushed
the
felix/102324-windows-no-webgpu
branch
from
13c0d0b
to
0ed26d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds.
Based on profiling on #2981, this is caused by the repo mapping stage for dawn taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected.