WPT: Autogenerate a test case for each test file #3076
+442
−344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npaun
force-pushed
the
npaun/wpt-test-config
branch
from
bc44728
to
4c4eb9f
Compare
anonrig
reviewed
Nov 7, 2024
| // Licensed under the Apache 2.0 license found in the LICENSE file or at: | ||
| // https://opensource.org/licenses/Apache-2.0 | ||
|
|
||
| export const config = { |
There was a problem hiding this comment.
Can you make this file typescript and make sure this config is properly typed?
|
Can we merge this as-is and do the TS conversion in a follow-up PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the WPT test harness to generate the JS glue code automatically:
-test.jsfile. This way don't have to manually edit our tests every time WPT adds a new test.-test-config.jsfile. A newignore: booloption is added to avoid loading test files we know are irrelevant for us.In addition, we'll now throw an error if any
expectedFailuresdidn't actually occur. This makes it simple to keep test config up to date as we fix compatibility with the WPT tests.