Instantiate Emscripten Runtime for python workers separately #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
force-pushed
the
dlapid/initialize_emscripten
branch
2 times, most recently
from
6d1d32c
to
8650f2a
Compare
danlapid
force-pushed
the
dlapid/initialize_emscripten
branch
from
8650f2a
to
269f706
Compare
|
Okay you should bump the backport number to 9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal PR # 9243.
This is the PR I should've opened a month and a half ago.
This changes basically nothing but separates the emscripten initialization to a separate step which runs in a separate context which we can later move around.