Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unused parts of old metrics implementation #7281

Draft
wants to merge 10 commits into
base: wrangler-telemetry
Choose a base branch
from

Conversation

emily-shen
Copy link
Contributor

removes sendMetricsEvents across the codebase, metrics headers on deploy and dispatcher.identify

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

emily-shen and others added 10 commits November 15, 2024 17:30
* add telemetry commands

* changeset

* fix and test dates

* update changeset

* add global/project status

* default true

* remove changeset

* update wrangler telemetry status
Co-authored-by: emily-shen <emily-shen@users.noreply.github.com>
Co-authored-by: Edmund Hung <me@edmund.dev>
@emily-shen emily-shen requested review from a team as code owners November 18, 2024 13:13
Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 8eb8ef4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893199322/npm-package-wrangler-7281

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7281/npm-package-wrangler-7281

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893199322/npm-package-wrangler-7281 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893199322/npm-package-create-cloudflare-7281 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893199322/npm-package-cloudflare-kv-asset-handler-7281
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893199322/npm-package-miniflare-7281
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893199322/npm-package-cloudflare-pages-shared-7281
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893199322/npm-package-cloudflare-vitest-pool-workers-7281
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893199322/npm-package-cloudflare-workers-editor-shared-7281
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893199322/npm-package-cloudflare-workers-shared-7281
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893199322/npm-package-cloudflare-workflows-shared-7281

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.87.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen marked this pull request as draft November 18, 2024 13:55
Base automatically changed from edmundhung/wrangler-telemetry to wrangler-telemetry November 19, 2024 12:14
@emily-shen emily-shen force-pushed the wrangler-telemetry branch 2 times, most recently from 4799bba to 153fd60 Compare November 21, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants