Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wrangler): enable telemetry by default #7291

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Nov 19, 2024

Fixes DEVX-1501.

Describe your change...


Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 1f7428a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 19, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976967207/npm-package-wrangler-7291

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7291/npm-package-wrangler-7291

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976967207/npm-package-wrangler-7291 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976967207/npm-package-create-cloudflare-7291 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976967207/npm-package-cloudflare-kv-asset-handler-7291
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976967207/npm-package-miniflare-7291
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976967207/npm-package-cloudflare-pages-shared-7291
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976967207/npm-package-cloudflare-vitest-pool-workers-7291
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976967207/npm-package-cloudflare-workers-editor-shared-7291
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976967207/npm-package-cloudflare-workers-shared-7291
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976967207/npm-package-cloudflare-workflows-shared-7291

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.90.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

emily-shen and others added 4 commits November 21, 2024 16:42
* add telemetry commands

* changeset

* fix and test dates

* update changeset

* add global/project status

* default true

* remove changeset

* update wrangler telemetry status
)

* add metrics alias

* tests

* use each to test alias
* stop collecting userId in telemetry

Co-authored-by: emily-shen <emily-shen@users.noreply.github.com>

* implement telemetry collection

* infer errorType based on the constructor name

* implement common event properties

* log common event properties

Co-authored-by: Edmund Hung <me@edmund.dev>

* respect metric enabled/disabled

* remove dispatcher.identify

* include SPARROW_SOURCE_KEY in PR pre-release build

* fix tests

* ensure debug log covers the request failed message

* replace SPARROW_SOURCE_KEY regardless whethe env exists

---------

Co-authored-by: Edmund Hung <edmund@cloudflare.com>
Co-authored-by: emily-shen <emily-shen@users.noreply.github.com>
Co-authored-by: Edmund Hung <me@edmund.dev>
* add banner

* abort if telemetry disable

* basic sendNewEvent tests

* banner tests

* settle promises before exiting

* remove unnecessary banner logic

* just check if version is different
* isCI and isNonInteractive

* add argsUsed and argsCombination

* don't include args if value is false

* redact arg values if string

* lint

* isNonInteractive -> isInteractive
@edmundhung edmundhung added the e2e Run e2e tests on a PR label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants