Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudflare_pages): add CI detection on deploy #7299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oritwoen
Copy link

This pull request adds support for autofilling parameters when deploying cloudflare pages using CI. Currently on GitLab I have to do something like this:

npx wrangler pages deploy dist --project-name cf-pages-project --commit-hash "$CI_COMMIT_SHORT_SHA" --commit-message "$CI_COMMIT_MESSAGE" --branch $CI_COMMIT_BRANCH

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: Deploy already contains tests and if it doesn't work correctly the current tests will detect it.
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: Deploy already contains tests and if it doesn't work correctly the current tests will detect it.
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: It should have worked this way from the beginning.

@oritwoen oritwoen requested review from a team as code owners November 20, 2024 12:10
Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: 83acd91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant