Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serve_directly option to assets configuration #7316

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

WillTaylorDev
Copy link
Contributor

@WillTaylorDev WillTaylorDev commented Nov 21, 2024

Provides serve_directly option in asset metadata

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not yet implemented on backend

@WillTaylorDev WillTaylorDev requested a review from a team as a code owner November 21, 2024 17:01
Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: 5163d06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/provide-serve-directly-metadata-option branch from 2c14c96 to 2829a22 Compare November 21, 2024 17:02
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/provide-serve-directly-metadata-option branch 3 times, most recently from cde71c1 to 7fdabdf Compare November 21, 2024 20:23
@petebacondarwin petebacondarwin requested a review from a team as a code owner November 21, 2024 21:22
Copy link
Contributor

github-actions bot commented Nov 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977512917/npm-package-wrangler-7316

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7316/npm-package-wrangler-7316

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977512917/npm-package-wrangler-7316 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977512917/npm-package-create-cloudflare-7316 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977512917/npm-package-cloudflare-kv-asset-handler-7316
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977512917/npm-package-miniflare-7316
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977512917/npm-package-cloudflare-pages-shared-7316
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977512917/npm-package-cloudflare-vitest-pool-workers-7316
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977512917/npm-package-cloudflare-workers-editor-shared-7316
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977512917/npm-package-cloudflare-workers-shared-7316
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977512917/npm-package-cloudflare-workflows-shared-7316

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.90.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/provide-serve-directly-metadata-option branch 3 times, most recently from c23f7cb to 84ab834 Compare November 22, 2024 14:14
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/provide-serve-directly-metadata-option branch 2 times, most recently from 224d506 to f85e37c Compare November 22, 2024 17:40
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/provide-serve-directly-metadata-option branch from f85e37c to 5163d06 Compare November 22, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

3 participants