Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make target help #1953

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/autoscaler/tasks/deploy-previous-autoscaler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ params:
# Optional: override the user to access bosh
BOSH_USERNAME: admin

# Optional: relative to the root of the release input. The files will be
# Optional: relative to the root of the release input. The files will be
# checked to see if they exist, if not they will be excluded from the list
OPS_FILES: |
example/operation/loggregator-certs-from-cf.yml
Expand Down
24 changes: 12 additions & 12 deletions scripts/deploy_acceptance_app.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -euo pipefail
script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
pushd "${script_dir}" > /dev/null
source ./vars.source.sh

Check warning on line 5 in scripts/deploy_acceptance_app.sh

View workflow job for this annotation

GitHub Actions / reviewdog

[shellcheck] reported by reviewdog 🐶 Not following: ./vars.source.sh: openBinaryFile: does not exist (No such file or directory) [SC1091](https://github.com/koalaman/shellcheck/wiki/SC1091) Raw Output: ./scripts/deploy_acceptance_app.sh:5:8:info:Not following: ./vars.source.sh: openBinaryFile: does not exist (No such file or directory) [SC1091](https://github.com/koalaman/shellcheck/wiki/SC1091)
test_app_name=test-app
#test_service_name=test-app-service
test_org="testing-pr-app"
Expand All @@ -14,18 +14,18 @@
service_offering="app-autoscaler-${pr_number}"

function create_app {
local app_name=$1
cf push --var app_name="${app_name}"\
--var app_domain=autoscaler.app-runtime-interfaces.ci.cloudfoundry.org\
--var service_name="${service_offering}"\
--var instances=1\
--var node_tls_reject_unauthorized=0\
-p "${app_location}"\
-f "${app_location}/app_manifest.yml"\
--no-start &
# cf bind-service "${app_name}" "${test_service_name}"
}
local app_name=$1
cf push --var app_name="${app_name}"\
--var app_domain=autoscaler.app-runtime-interfaces.ci.cloudfoundry.org\
--var service_name="${service_offering}"\
--var instances=1\
--var node_tls_reject_unauthorized=0\
-p "${app_location}"\
-f "${app_location}/app_manifest.yml"\
--no-start &

# cf bind-service "${app_name}" "${test_service_name}"
}

# shellcheck disable=SC1091
cf create-org "${test_org}"
Expand Down
24 changes: 24 additions & 0 deletions scripts/print_parameters.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#! /usr/bin/env bash

set -eu -o pipefail

# This function gets a list of names of shell-parameters and prints
# them as well as its values
function print_parameters () {
local -a -r param_list=("$@")
for param_name in "${param_list[@]}"
do
echo "${param_name} = ${!param_name}"
done
}

function print_help_for_parameters () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
The mentioned syntax error was in this function. SC1009

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
Couldn't parse this brace group. Fix to allow more checks. SC1073

# TODO
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
You need at least one command here. Use 'true;' as a no-op. SC1055

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
Unexpected keyword/token. Fix any mentioned problems and try again. SC1072


# When called as a script
if [ "${0}" = "${BASH_SOURCE[0]}" ]
then
# https://stackoverflow.com/a/3816747
print_parameters "$@"
fi
3 changes: 1 addition & 2 deletions scripts/sync-package-specs
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,4 @@ sync_package metricsforwarder metricsforwarder -app ./...
sync_package metricsgateway metricsgateway -app ./...
sync_package metricsserver metricsserver -app ./...
sync_package operator operator -app ./...
sync_package scalingengine scalingengine -app ./...

sync_package scalingengine scalingengine -app ./...
Loading