-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add make target help #1953
Add make target help #1953
Changes from 2 commits
57f6ca6
6686466
283c57d
93765a8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
set -euo pipefail | ||
script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )" | ||
pushd "${script_dir}" > /dev/null | ||
source ./vars.source.sh | ||
Check warning on line 5 in scripts/deploy_acceptance_app.sh GitHub Actions / reviewdog
|
||
test_app_name=test-app | ||
#test_service_name=test-app-service | ||
test_org="testing-pr-app" | ||
|
@@ -14,18 +14,18 @@ | |
service_offering="app-autoscaler-${pr_number}" | ||
|
||
function create_app { | ||
local app_name=$1 | ||
cf push --var app_name="${app_name}"\ | ||
--var app_domain=autoscaler.app-runtime-interfaces.ci.cloudfoundry.org\ | ||
--var service_name="${service_offering}"\ | ||
--var instances=1\ | ||
--var node_tls_reject_unauthorized=0\ | ||
-p "${app_location}"\ | ||
-f "${app_location}/app_manifest.yml"\ | ||
--no-start & | ||
# cf bind-service "${app_name}" "${test_service_name}" | ||
} | ||
local app_name=$1 | ||
cf push --var app_name="${app_name}"\ | ||
--var app_domain=autoscaler.app-runtime-interfaces.ci.cloudfoundry.org\ | ||
--var service_name="${service_offering}"\ | ||
--var instances=1\ | ||
--var node_tls_reject_unauthorized=0\ | ||
-p "${app_location}"\ | ||
-f "${app_location}/app_manifest.yml"\ | ||
--no-start & | ||
|
||
# cf bind-service "${app_name}" "${test_service_name}" | ||
} | ||
|
||
# shellcheck disable=SC1091 | ||
cf create-org "${test_org}" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#! /usr/bin/env bash | ||
|
||
set -eu -o pipefail | ||
|
||
# This function gets a list of names of shell-parameters and prints | ||
# them as well as its values | ||
function print_parameters () { | ||
local -a -r param_list=("$@") | ||
for param_name in "${param_list[@]}" | ||
do | ||
echo "${param_name} = ${!param_name}" | ||
done | ||
} | ||
|
||
function print_help_for_parameters () { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
# TODO | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
# When called as a script | ||
if [ "${0}" = "${BASH_SOURCE[0]}" ] | ||
then | ||
# https://stackoverflow.com/a/3816747 | ||
print_parameters "$@" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
The mentioned syntax error was in this function. SC1009