Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acceptance-tests #29

Merged
merged 24 commits into from
Jul 5, 2023
Merged

acceptance-tests #29

merged 24 commits into from
Jul 5, 2023

Conversation

peanball
Copy link
Contributor

@peanball peanball commented Jun 5, 2023 •
edited by domdom82
Loading

  • Prepared test suite environment
  • Added one basic integration test
  • Added several fixes of bugs that surfaced during tests

Successful integration test run: https://concourse.cfi.sapcloud.io/teams/main/pipelines/pcap-release-dev/jobs/acceptance-tests/builds/89

@domdom82 domdom82 force-pushed the acceptance-tests branch 9 times, most recently from 217858a to cdd5b2d Compare June 22, 2023 11:48
@domdom82 domdom82 force-pushed the acceptance-tests branch 8 times, most recently from f7739c5 to 627b018 Compare June 23, 2023 12:28
peanball added a commit that referenced this pull request Jun 23, 2023
@peanball
fix(ci): Remove dependabot entry for acceptance tests
b44a4cc 
They will be added with #29
plowin pushed a commit that referenced this pull request Jun 23, 2023
@peanball
Add dependabot to pcap-release (#32)
f7ec913 
* feat(ci): add dependabot bumps for dependencies

* fix(ci): Remove dependabot entry for acceptance tests
They will be added with #29
@domdom82 domdom82 force-pushed the acceptance-tests branch 7 times, most recently from 8695a4b to 87c919d Compare June 30, 2023 12:27
@domdom82 domdom82 force-pushed the acceptance-tests branch 2 times, most recently from c72613d to 3872f9c Compare June 30, 2023 14:12
b1tamara and others added 2 commits June 30, 2023 16:43
@domdom82 domdom82 marked this pull request as ready for review July 3, 2023 07:35
@domdom82 domdom82 requested a review from a team as a code owner July 3, 2023 07:35
@domdom82 domdom82 requested a review from b1tamara July 3, 2023 09:02
peanball
peanball commented Jul 3, 2023
View reviewed changes
Copy link
Contributor Author

@peanball peanball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really appreciate if we added descriptions with the logical expectation for each of the Expect() statements.

Failures are then much more easily identified by looking at the logs, and it helps see, verify or question the test expectations.

acceptance-tests/basic_pcap_test.go Show resolved Hide resolved
acceptance-tests/basic_pcap_test.go Show resolved Hide resolved
acceptance-tests/acceptance_tests_suite_test.go Outdated Show resolved Hide resolved
peanball
peanball commented Jul 3, 2023
View reviewed changes
acceptance-tests/basic_pcap_test.go Outdated Show resolved Hide resolved
acceptance-tests/basic_pcap_test.go Outdated Show resolved Hide resolved
acceptance-tests/basic_pcap_test.go Show resolved Hide resolved
acceptance-tests/bosh_helpers.go Show resolved Hide resolved
acceptance-tests/bosh_helpers.go Outdated Show resolved Hide resolved
acceptance-tests/remote.go Outdated Show resolved Hide resolved
acceptance-tests/remote.go Show resolved Hide resolved
ci/scripts/start-bosh.sh Show resolved Hide resolved
src/pcap/cmd/pcap-bosh-cli/main.go Show resolved Hide resolved
src/pcap/cmd/pcap-bosh-cli/main.go Show resolved Hide resolved
b1tamara
b1tamara reviewed Jul 3, 2023
View reviewed changes
src/pcap/cmd/pcap-bosh-cli/main.go Show resolved Hide resolved
src/pcap/cmd/pcap-bosh-cli/main.go Outdated Show resolved Hide resolved
ci/scripts/shell Show resolved Hide resolved
manifests/pcap-acceptance-tests.yml Outdated Show resolved Hide resolved
acceptance-tests/config.go Show resolved Hide resolved
@domdom82
Copy link
Contributor

domdom82 commented Jul 3, 2023

Green integration test after code review changes applied: https://concourse.cfi.sapcloud.io/teams/main/pipelines/pcap-release-dev/jobs/acceptance-tests/builds/92

peanball
peanball commented Jul 4, 2023
View reviewed changes
Copy link
Contributor Author

@peanball peanball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really like to avoid introducing new technical dept, even if we reuse test code / scripts from HAProxy. Those are not or barely documented. This is the ideal opportunity to improve.

We can / will still unify across haproxy and pcap releases, but if we have a better base to jump off from that would be beneficial for both projects.

acceptance-tests/basic_pcap_test.go Outdated Show resolved Hide resolved
acceptance-tests/bosh_helpers.go
}
}

func downloadFile(info pcapInfo, remotePath string, localFile *os.File, permissions os.FileMode) error {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a follow-up for unifying this. But I also don't want to accept new technical dept into pcap because we just copied from HAProxy. What we build here can be the base of the unified version that we'd also use in HAProxy.

acceptance-tests/remote.go Outdated Show resolved Hide resolved
ci/scripts/shell Show resolved Hide resolved
b1tamara
b1tamara reviewed Jul 4, 2023
View reviewed changes
acceptance-tests/README.md Outdated Show resolved Hide resolved
@domdom82 domdom82 merged commit 5338709 into main Jul 5, 2023
@domdom82 domdom82 deleted the acceptance-tests branch July 5, 2023 13:13
@CFN-CI
Copy link
Contributor

CFN-CI commented Jul 14, 2023

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1tamara b1tamara b1tamara left review comments

@domdom82 domdom82 domdom82 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peanball @domdom82 @CFN-CI @b1tamara