Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pcap-agent): Make default config work again w/o TLS. #99

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix(pcap-agent): Make default config work again w/o TLS. #99

merged 1 commit into from
Jul 25, 2023

Conversation

domdom82
Copy link
Contributor

  • pcap-agent is unusable w/o TLS right now.
  • it provides a "defaultConfig" that does not use TLS.
  • so it can't be started w/o proper TLS config, which harms development speed.
  • this PR makes the default config usable again and allows you to start pcap-agent without a config file.

@domdom82 domdom82 requested a review from a team as a code owner July 24, 2023 15:27
@domdom82 domdom82 added the run-ci Triggers PR Validation label Jul 24, 2023
maxmoehl
maxmoehl previously approved these changes Jul 25, 2023
View reviewed changes
@domdom82 domdom82 enabled auto-merge (squash) July 25, 2023 08:56
@domdom82 domdom82 merged commit 0358ab0 into cloudfoundry:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmoehl maxmoehl maxmoehl approved these changes

Assignees
No one assigned
Labels
run-ci Triggers PR Validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domdom82 @maxmoehl