Skip to content

Commit

Permalink
Return pointer to struct to match interface signature
Browse files Browse the repository at this point in the history
  • Loading branch information
aramprice committed Jul 19, 2024
1 parent 4c4af0f commit 6d0c780
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion package_stemcell/factory/packager_factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func (f *PackagerFactory) Packager(sourceConfig config.SourceConfig, outputConfi
case config.VMDK:
options := package_parameters.VmdkPackageParameters{}
logger := colorlogger.ConstructLogger(logLevel, color, os.Stderr)
vmdkPackager := packagers.VmdkPackager{
vmdkPackager := &packagers.VmdkPackager{
Stop: make(chan struct{}),
Debugf: logger.Debugf,
BuildOptions: options,
Expand Down
8 changes: 4 additions & 4 deletions package_stemcell/factory/packager_factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ var _ = Describe("Factory", func() {
actualPackager, err := packagerFactory.Packager(sourceConfig, outputConfig, 0, false)
Expect(err).NotTo(HaveOccurred())

Expect(actualPackager).To(BeAssignableToTypeOf(packagers.VmdkPackager{}))
Expect(actualPackager).NotTo(BeAssignableToTypeOf(packagers.VCenterPackager{}))
Expect(actualPackager).To(BeAssignableToTypeOf(&packagers.VmdkPackager{}))
Expect(actualPackager).NotTo(BeAssignableToTypeOf(&packagers.VCenterPackager{}))
})
})

Expand All @@ -50,8 +50,8 @@ var _ = Describe("Factory", func() {
actualPackager, err := packagerFactory.Packager(sourceConfig, outputConfig, 0, false)
Expect(err).NotTo(HaveOccurred())

Expect(actualPackager).To(BeAssignableToTypeOf(packagers.VCenterPackager{}))
Expect(actualPackager).NotTo(BeAssignableToTypeOf(packagers.VmdkPackager{}))
Expect(actualPackager).To(BeAssignableToTypeOf(&packagers.VCenterPackager{}))
Expect(actualPackager).NotTo(BeAssignableToTypeOf(&packagers.VmdkPackager{}))
})
})

Expand Down

0 comments on commit 6d0c780

Please sign in to comment.