Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code #35

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Remove unused code #35

merged 1 commit into from
Jul 23, 2024

Conversation

aramprice
Copy link
Member

This code was only referenced by tests. Possibly was an unfinished refactor.

@aramprice
Remove unused code
b161ff4 
This code was only referenced by tests. Possibly was an unfinished
refactor.
@aramprice aramprice requested review from ystros and selzoc July 23, 2024 19:41
selzoc
selzoc approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@selzoc selzoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to build the stembuild executable, and all tests (except ones that require ovftool since i don't have that) pass.

ystros
ystros approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ystros ystros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked for any usages of package_stemcell outside of this project either (e.g. in a pipeline defined in another repo) and did not find any.

@ystros ystros merged commit 2ba414c into master Jul 23, 2024
4 checks passed
@ystros ystros deleted the remove-unused-code branch July 23, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ystros ystros ystros approved these changes

@selzoc selzoc selzoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aramprice @ystros @selzoc