Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc Fixes and Updates #1763

Merged
merged 9 commits into from
Nov 21, 2024
Merged

Misc Fixes and Updates #1763

merged 9 commits into from
Nov 21, 2024

Conversation

aauren
Copy link
Collaborator

@aauren aauren commented Nov 17, 2024

This PR is a conglomerate of a couple of fixes and features:

@mrueg @twz123 @rbrtbnfgl @zmedico

  • Most notably, the hope is that this will be a final, less complicated fix for: kube-router Holding on to Routes #1738
  • Refactors health checking to be more robust
  • Adds health checking to the route_sync controller
  • Adds metrics to the route_sync controller to make it more obvious how healthy it is and if it is gaining routes in the future
  • Fixes some linting problems with tests

aauren and others added 9 commits November 17, 2024 17:55
@aauren
fix(node_test.go): some minor unit test errors & verbiage
f881087
@aauren
fix: remove unreachable / redundant error condition
5bd1783
@aauren
fix(Makefile): remove slashes from container tags on push
fcfc0c2
@aauren
fix(injectRoute): ensure routes is removed from map
8f9b197 
There are a couple of items that have typically ended up in a no-op for
us when considering routes to inject. However, now that we have a route
map where we track route state, we need this not just to be no-ops, but
also update the route state cache as well to ensure that the route
doesn't get replaced in the future.

When we find tunnels to clean up, we need to not only remove the tunnel
and the route to that tunnel, but also remove the route from the state
map.

When we discover that no route needs to be added to the host because
it's not in the same subnet and we weren't supposed to create a tunnel,
then we also clean it up and ensure that it isn't in our state as well.
@aauren
fix(ecmp_vip.go): logging levels to be more helpful
69080ef
@aauren
fact(healthcontroller): make more robust
723ddef 
Make the health controller more robust and extensible by adding in
constants for heart beats instead of 3 character random strings that are
easy to get wrong.
@aauren
feat(.gitignore): update ignores to be more specific
0b8d831
@aauren
feat(route_sync): add health checking
320dd5c
@aauren
feat(route_sync): add metrics
8c1c3ca
@mrueg mrueg merged commit 8c5cc3e into master Nov 21, 2024
7 checks passed
@mrueg mrueg deleted the misc_fixes_and_updates branch November 21, 2024 14:24
@aauren aauren mentioned this pull request Nov 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrueg mrueg mrueg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aauren @mrueg