OpenTofu support #98
OpenTofu support #98
Conversation
mergify
bot
added
triage
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
migrate/lib/golang.sh
Outdated
| function update_terratest() { | ||
| if [ -f test/src/go.mod ]; then | ||
| info "Updating terratest" | ||
| cd test/src | ||
| go get -u github.com/gruntwork-io/terratest | ||
| go mod tidy | ||
| cd - | ||
|
|
||
| git add test/src/go.mod | ||
| git add test/src/go.sum | ||
| fi | ||
| } |
There was a problem hiding this comment.
I'm worried about this. The upgrade will upgrade not just Terratest, but also its dependencies, and I fear it will cause spurious failures.
For example, terratest v0.44.0 requires go version 1.21 or later. Many of our tests are still at go 1.20, and some even older.
Also, terratest v0.46.8:
Updated k8s.io/apimachinery from v0.27.2 to v0.28.4.
Updated k8s.io/client-go from v0.27.2 to v0.28.4.
This means that if we have examples deploying Kubernetes clusters version 1.26 or older, we run the risk of having client errors.
I think we need to be cautious about this.
| update_terratest | ||
|
|
||
| # Merge the PR | ||
| auto_merge |
There was a problem hiding this comment.
Let's please make sure that the merge does not trigger a new release of the module.
There was a problem hiding this comment.
We automatically add no-release label to PRs programmatically generated.
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <erik@cloudposse.com>
mergify
bot
removed
needs-cloudposse
what
>= 0.46.0why
References