Added Changelog page for components #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Aug 29, 2023
docusaurus.config.js
Outdated
| require.resolve('./src/plugins/changelog/index.js'), | ||
| { | ||
| blogTitle: 'Components Changelog', | ||
| blogDescription: 'Keep yourself up-to-date about new features in every release', |
There was a problem hiding this comment.
Suggested change
| blogDescription: 'Keep yourself up-to-date about new features in every release', | |
| blogDescription: 'Stay informed about new features and breaking changes in every release', |
osterman
reviewed
Aug 29, 2023
docusaurus.config.js
Outdated
| authorsMapPath: 'authors.json', | ||
| feedOptions: { | ||
| type: 'all', | ||
| title: 'Cloud Posse components changelog', |
There was a problem hiding this comment.
Suggested change
| title: 'Cloud Posse components changelog', | |
| title: 'Cloud Posse Components Changelog', |
osterman
reviewed
Aug 29, 2023
Comment on lines
4
to
5
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. |
There was a problem hiding this comment.
We need to correct this. Correct this language by adding the LICENSE to the ChangelogItem/ folder. See https://github.com/grafana/grafana/blob/main/NOTICE.md for example.
There was a problem hiding this comment.
Update this file and related files.
zdmytriv
commented
Aug 29, 2023
| @@ -61,7 +61,8 @@ jobs: | |||
| with: | |||
| fetch-depth: 1 | |||
| repository: cloudposse/terraform-aws-components | |||
| ref: main | |||
| # ref: main | |||
| ref: upgrade-guide-workflow | |||
There was a problem hiding this comment.
this should be fixed before merge
milldr
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Added Changelog page for components
why
references