Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about input errors with object inputs, remove DNS section #606

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Mar 12, 2024

what

  • Warn about input errors being silently ignored with object inputs
  • Remove DNS section from Terraform Best Practices
  • Incorporate some changes from fixed typos in docs #584 and update some others, thanks @whyevenquestion1t
  • Enhance site builder to render README.yaml of sub-modules when present

why

  • Non-obvious behavior can lead to serious consequences
  • Recommendations about DNS configuration are not relevant to Terraform
  • Supersedes and closes fixed typos in docs #584, which is not completely ready to merge and is nearly a year old
  • Submodule README.md is expected to be plain. If it is generated by README.yaml, then parse it like we do for top-level modules so we do not get the extra stuff that breaks Docusaurus.

@Nuru Nuru merged commit 095d66b into master Mar 14, 2024
3 checks passed
@Nuru Nuru deleted the arb-232 branch March 14, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants