-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dynamodb scan with query #31
base: main
Are you sure you want to change the base?
Conversation
…sse/github-action-terraform-plan-storage into replace-dynamodb-scan-with-query * 'replace-dynamodb-scan-with-query' of github.com:cloudposse/github-action-terraform-plan-storage: Update contents of the dist directory
FilterExpression: | ||
"#owner = :owner and #repo = :repo and #commitSHA = :commitSHA and #component = :component and #stack = :stack", | ||
"#owner = :owner and #repo = :repo and #component = :component and #stack = :stack", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing the condition to match the commit SHA? I don't see how this could be correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcalhoun because we filter sha with KeyCondition
https://github.com/cloudposse/github-action-terraform-plan-storage/pull/31/files#diff-95366d8215594fbafa600c4d01acd3040d43de241933dcf7a6ad86ead80e391aR33
KeyConditionExpression: "#commitSHA= :commitSHA",
what
DynamoDB
scan
withquery
why
If the total size of scanned items exceeds the maximum dataset size limit of 1 MB, the scan completes and results are returned to the user. The LastEvaluatedKey value is also returned and the requestor can use the LastEvaluatedKey to continue the scan in a subsequent operation.
query
is cheaper thenscan
false negatives
get plan casesreferences
Migration