Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add extra tests on tools/drawer alias behavior #3052

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

just-boris
Copy link
Member

Description

Ensure findTools and findActiveDrawer test utils always work as expected

Related links, issue #, if available: AWSUI-59987

How has this been tested?

Test only change

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

describeEachAppLayout({ themes: ['classic', 'refresh', 'refresh-toolbar'] }, ({ theme, size }) => {
describeEachAppLayout(({ theme, size }) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is all themes by default, so we can remove this array

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (c59e8fd) to head (182d406).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3052   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         780      780           
  Lines       21921    21921           
  Branches     7097     7097           
=======================================
  Hits        21119    21119           
  Misses        795      795           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@just-boris just-boris marked this pull request as ready for review November 22, 2024 16:54
@just-boris just-boris requested a review from a team as a code owner November 22, 2024 16:54
@just-boris just-boris requested review from michaeldowseza and removed request for a team November 22, 2024 16:54
@dpitcock dpitcock self-assigned this Nov 25, 2024
@dpitcock dpitcock self-requested a review November 25, 2024 09:37
@dpitcock dpitcock removed their assignment Nov 25, 2024
@just-boris just-boris added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit ea46162 Nov 25, 2024
38 checks passed
@just-boris just-boris deleted the tools-finder-test branch November 25, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants