Merged PR 271: v0.8.13 demo build

fixes for 0.8.13; merged branch between main/ira and main/brandon for 0.8.13 release Related work items: #644, #645, #646, #649, #650, #652, #653, #655, #656, #657, #658
cloudsmithconsulting · Feb 21, 2020 · 1359431 · 1359431
2 parents aca7b4b + 2da201d
commit 1359431
Show file tree

Hide file tree

Showing 54 changed files with 678 additions and 416 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -12,6 +12,20 @@ All notable changes to the "cds-for-code" extension will be documented in this f
 
 ## v0.8 Early Preview - December 2019 - January 2020
 
+### v0.8.13 (February 21, 2020)
+
+- Feature: Code Generation: Fix button styling on UX ([#649](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_workitems/edit/649/))
+- Feature: Icons: Proper icon resolution with iconify for UX ([#650](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_workitems/edit/650/))
+- Feature: Confirm delete of plugin steps and plugin step images ([#655](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_workitems/edit/655/))
+- Feature: Plugin step and step image dialog should refresh treeview on exit ([#656](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_workitems/edit/656/))
+- Bugfix: Webviews showing templating tokens in content ([#645](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_workitems/edit/645/))
+- Bugfix: Code generation emits invalid names in option sets ([#646](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_workitems/edit/646/))
+- Bugfix: Cloned objects stopped respecting excluded properties ([#652](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_workitems/edit/652/))
+- Bugfix: Error when generation code missing entity on attribute filter ([#653](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_workitems/edit/653/))
+- Bugfix: Code generation doesn't black list attributes on white listed entity ([#654](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_workitems/edit/654/))
+- Bugfix: Passwords containing certain characters rejected during code generation ([#657](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_workitems/edit/657/))
+- Bugfix: Code generation not emitting getter and setter on some properties ([#658](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_workitems/edit/658/))
+
 ### v0.8.12 (February 13, 2020)
 
 - Bugfix: Users received &quot;Authentication for this request failed.&quot; error when accessing non-US environments (reported on GitHub) ([GitHub Issue #10](https://github.com/cloudsmithconsulting/cds-for-code/issues/10) | [#636](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_workitems/edit/636/))

diff --git a/README.md b/README.md
@@ -6,7 +6,7 @@ This extension is designed to help developers with a simple development loop for
 
 |Version|Link||
 |:--|:--|:--|
-|Release Version:|[0.8.12](https://github.com/cloudsmithconsulting/cds-for-code/releases/tag/v0.8.12)|![Marketplace: Version](https://flat.badgen.net/vs-marketplace/v/cloudsmithconsulting.cds-for-code) ![Marketplace: Installs](https://flat.badgen.net/vs-marketplace/i/cloudsmithconsulting.cds-for-code) ![Marketplace: Downloads](https://flat.badgen.net/vs-marketplace/d/cloudsmithconsulting.cds-for-code) ![Marketplace: Rating](https://flat.badgen.net/vs-marketplace/rating/cloudsmithconsulting.cds-for-code) ![Open Issues](https://flat.badgen.net/github/open-issues/cloudsmithconsulting/cds-for-code) ![Stars](https://flat.badgen.net/github/stars/cloudsmithconsulting/cds-for-code)|
+|Release Version:|[0.8.13](https://github.com/cloudsmithconsulting/cds-for-code/releases/tag/v0.8.13)|![Marketplace: Version](https://flat.badgen.net/vs-marketplace/v/cloudsmithconsulting.cds-for-code) ![Marketplace: Installs](https://flat.badgen.net/vs-marketplace/i/cloudsmithconsulting.cds-for-code) ![Marketplace: Downloads](https://flat.badgen.net/vs-marketplace/d/cloudsmithconsulting.cds-for-code) ![Marketplace: Rating](https://flat.badgen.net/vs-marketplace/rating/cloudsmithconsulting.cds-for-code) ![Open Issues](https://flat.badgen.net/github/open-issues/cloudsmithconsulting/cds-for-code) ![Stars](https://flat.badgen.net/github/stars/cloudsmithconsulting/cds-for-code)|
 |Development Version:|[0.9.0](https://github.com/cloudsmithconsulting/cds-for-code/releases/tag/v0.9.0)|[![Board Status](https://dev.azure.com/cloudsmith-consulting/c20ca92d-a9a9-45af-8bdb-da3ce0803b59/b63fc4c8-773b-4ffc-ac61-c71890277c2c/_apis/work/boardbadge/350decde-59a7-49b4-a6f6-ee220fa7e391)](https://dev.azure.com/cloudsmith-consulting/c20ca92d-a9a9-45af-8bdb-da3ce0803b59/_boards/board/t/b63fc4c8-773b-4ffc-ac61-c71890277c2c/Microsoft.RequirementCategory/) [![Build Status](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_apis/build/status/cds-for-code?branchName=master)](https://dev.azure.com/cloudsmith-consulting/CloudSmith/_build/latest?definitionId=2&branchName=master) [![Release Status](https://vsrm.dev.azure.com/cloudsmith-consulting/_apis/public/Release/badge/c20ca92d-a9a9-45af-8bdb-da3ce0803b59/1/2)](https://vsrm.dev.azure.com/cloudsmith-consulting/_apis/public/Release/badge/c20ca92d-a9a9-45af-8bdb-da3ce0803b59/1/2)|
 
 ---
@@ -21,10 +21,8 @@ This extension is designed to help developers with a simple development loop for
   - [Features](#features)
   - [Commands](#commands)
     - [Commands and Descriptions](#commands-and-descriptions)
-    - [These commands can be executed directly through the VSCode command palette](#these-commands-can-be-executed-directly-through-the-vscode-command-palette)
   - [Settings](#settings)
     - [Settings and Descriptions](#settings-and-descriptions)
-    - [These settings are editable inside the VSCode Settings Editor](#these-settings-are-editable-inside-the-vscode-settings-editor)
   - [Known Issues](#known-issues)
   - [Change Log](#change-log)
   - [Contributors](#contributors)

diff --git a/docs/extension/Contributors.md b/docs/extension/Contributors.md
@@ -20,6 +20,7 @@ feedback, spot bugs and log issues so that we could deliver a better quality exp
 
 - Brandon Kelly
 - Ira Mellor
+- Scott Farriss
 - Gregory Moncayo
 - Jonas Rapp
 - Nikita Polyakov

diff --git a/...ion/api/classes/_components_solutions_webresourcemanager_.webresourcemanager.md b/...ion/api/classes/_components_solutions_webresourcemanager_.webresourcemanager.md
@@ -32,7 +32,7 @@ sidebar_label: "WebResourceManager"
 
 ▸ **compareWebResource**(`defaultUri?`: Uri): *Promise‹void›*
 
-Defined in src/components/Solutions/WebResourceManager.ts:50
+Defined in src/components/Solutions/WebResourceManager.ts:54
 
 **Parameters:**
 
@@ -48,7 +48,7 @@ ___
 
 ▸ **createWebResource**(`config?`: [Config](../interfaces/_api_cds_webapi_cdswebapi_.cdswebapi.config.md), `solutionId?`: string, `webResource?`: any, `fileUri?`: Uri, `defaultName`: string, `inform`: boolean): *Promise‹any›*
 
-Defined in src/components/Solutions/WebResourceManager.ts:45
+Defined in src/components/Solutions/WebResourceManager.ts:49
 
 **Parameters:**
 
@@ -69,7 +69,7 @@ ___
 
 ▸ **getSolutionMapping**(`fsPath?`: string, `orgId?`: string, `solutionId?`: string): *Promise‹[SolutionWorkspaceMapping](_components_solutions_solutionworkspacemapping_.solutionworkspacemapping.md)›*
 
-Defined in src/components/Solutions/WebResourceManager.ts:64
+Defined in src/components/Solutions/WebResourceManager.ts:68
 
 **Parameters:**
 
@@ -87,7 +87,7 @@ ___
 
 ▸ **getWebResourceDetails**(`fsPath`: string | undefined): *Promise‹any›*
 
-Defined in src/components/Solutions/WebResourceManager.ts:90
+Defined in src/components/Solutions/WebResourceManager.ts:94
 
 **Parameters:**
 
@@ -103,7 +103,7 @@ ___
 
 ▸ **getWebResourceType**(`extension`: string): *number | undefined*
 
-Defined in src/components/Solutions/WebResourceManager.ts:77
+Defined in src/components/Solutions/WebResourceManager.ts:81
 
 **Parameters:**
 
@@ -119,7 +119,7 @@ ___
 
 ▸ **packWebResource**(`config?`: [Config](../interfaces/_api_cds_webapi_cdswebapi_.cdswebapi.config.md), `solution?`: any, `webResource?`: any, `fileUri?`: Uri, `inform`: boolean): *Promise‹void›*
 
-Defined in src/components/Solutions/WebResourceManager.ts:55
+Defined in src/components/Solutions/WebResourceManager.ts:59
 
 **Parameters:**
 
@@ -139,7 +139,7 @@ ___
 
 ▸ **unpackWebResource**(`config?`: [Config](../interfaces/_api_cds_webapi_cdswebapi_.cdswebapi.config.md), `webResource?`: any, `fileUri?`: Uri, `autoOpen`: boolean): *Promise‹void›*
 
-Defined in src/components/Solutions/WebResourceManager.ts:60
+Defined in src/components/Solutions/WebResourceManager.ts:64
 
 **Parameters:**
 
@@ -158,7 +158,7 @@ ___
 
 ▸ **upsertWebResource**(`config`: [Config](../interfaces/_api_cds_webapi_cdswebapi_.cdswebapi.config.md), `webResource`: any, `solution?`: any): *Promise‹any›*
 
-Defined in src/components/Solutions/WebResourceManager.ts:118
+Defined in src/components/Solutions/WebResourceManager.ts:122
 
 **Parameters:**
 
@@ -176,7 +176,7 @@ ___
 
 ▸ **writeDataXmlFile**(`map`: [SolutionWorkspaceMapping](_components_solutions_solutionworkspacemapping_.solutionworkspacemapping.md), `webResource`: any, `fsPath`: string, `updateCustomizationsFile`: boolean): *Promise‹void›*
 
-Defined in src/components/Solutions/WebResourceManager.ts:140
+Defined in src/components/Solutions/WebResourceManager.ts:144
 
 **Parameters:**
 
@@ -211,7 +211,7 @@ ___
 
 ▸ **packWebResourceFromUri**(`uri?`: Uri): *Promise‹any›*
 
-Defined in src/components/Solutions/WebResourceManager.ts:36
+Defined in src/components/Solutions/WebResourceManager.ts:38
 
 **Parameters:**
 

diff --git a/docs/extension/api/classes/_core_utilities_.utilities.md b/docs/extension/api/classes/_core_utilities_.utilities.md
@@ -28,7 +28,7 @@ sidebar_label: "Utilities"
 
 • **get $Object**(): *[ObjectUtility](../interfaces/_core_utilities_.objectutility.md)*
 
-Defined in src/core/Utilities.ts:75
+Defined in src/core/Utilities.ts:76
 
 **Returns:** *[ObjectUtility](../interfaces/_core_utilities_.objectutility.md)*
 
@@ -38,7 +38,7 @@ ___
 
 • **get Async**(): *[AsyncUtility](../interfaces/_core_utilities_.asyncutility.md)*
 
-Defined in src/core/Utilities.ts:71
+Defined in src/core/Utilities.ts:72
 
 **Returns:** *[AsyncUtility](../interfaces/_core_utilities_.asyncutility.md)*
 
@@ -48,7 +48,7 @@ ___
 
 • **get Browser**(): *[BrowserUtility](../interfaces/_core_utilities_.browserutility.md)*
 
-Defined in src/core/Utilities.ts:72
+Defined in src/core/Utilities.ts:73
 
 **Returns:** *[BrowserUtility](../interfaces/_core_utilities_.browserutility.md)*
 
@@ -58,7 +58,7 @@ ___
 
 • **get Encoding**(): *[EncodingUtility](../interfaces/_core_utilities_.encodingutility.md)*
 
-Defined in src/core/Utilities.ts:73
+Defined in src/core/Utilities.ts:74
 
 **Returns:** *[EncodingUtility](../interfaces/_core_utilities_.encodingutility.md)*
 
@@ -68,7 +68,7 @@ ___
 
 • **get Guid**(): *[GuidUtility](../interfaces/_core_utilities_.guidutility.md)*
 
-Defined in src/core/Utilities.ts:74
+Defined in src/core/Utilities.ts:75
 
 **Returns:** *[GuidUtility](../interfaces/_core_utilities_.guidutility.md)*
 
@@ -78,7 +78,7 @@ ___
 
 • **get Random**(): *[RandomUtility](../interfaces/_core_utilities_.randomutility.md)*
 
-Defined in src/core/Utilities.ts:76
+Defined in src/core/Utilities.ts:77
 
 **Returns:** *[RandomUtility](../interfaces/_core_utilities_.randomutility.md)*
 
@@ -88,6 +88,6 @@ ___
 
 • **get String**(): *[StringUtility](../interfaces/_core_utilities_.stringutility.md)*
 
-Defined in src/core/Utilities.ts:77
+Defined in src/core/Utilities.ts:78
 
 **Returns:** *[StringUtility](../interfaces/_core_utilities_.stringutility.md)*
diff --git a/docs/extension/api/classes/_core_webui_viewrenderer_.viewrenderer.md b/docs/extension/api/classes/_core_webui_viewrenderer_.viewrenderer.md
@@ -271,15 +271,15 @@ ___
 
 ###  render
 
-▸ **render**(`htmlParial`: string, `useCsp?`: boolean): *string*
+▸ **render**(`htmlPartial`: string, `useCsp?`: boolean): *string*
 
-Defined in src/core/webui/ViewRenderer.ts:96
+Defined in src/core/webui/ViewRenderer.ts:98
 
 **Parameters:**
 
 Name | Type |
 ------ | ------ |
-`htmlParial` | string |
+`htmlPartial` | string |
 `useCsp?` | boolean |
 
 **Returns:** *string*

diff --git a/.../extension/api/classes/_views_cs_cds_viewcontainers_cdsexplorer_.cdsexplorer.md b/.../extension/api/classes/_views_cs_cds_viewcontainers_cdsexplorer_.cdsexplorer.md
@@ -231,8 +231,8 @@ ___
                 Utilities.Browser.openWindow(CdsUrlResolver.getManageWebResourceUri(item.config, undefined, item.solutionId));
             }
         }},
-        { key: "PluginType", value: async (item) => await vscode.commands.executeCommand(cs.cds.controls.pluginStep.open, item.context._pluginassemblyid_value, item.config, undefined) },
-        { key: "PluginStep", value: async (item) => await vscode.commands.executeCommand(cs.cds.controls.pluginStepImage.open, item.context.sdkmessageprocessingstepid, undefined, item.config) }
+        { key: "PluginType", value: async (item) => await vscode.commands.executeCommand(cs.cds.controls.pluginStep.open, item.context._pluginassemblyid_value, undefined, item.config, item) },
+        { key: "PluginStep", value: async (item) => await vscode.commands.executeCommand(cs.cds.controls.pluginStepImage.open, item.context.sdkmessageprocessingstepid, undefined, item.config, item) }
     ])
 
 Defined in src/views/cs.cds.viewContainers.cdsExplorer.ts:60
@@ -278,8 +278,8 @@ ___
                 Utilities.Browser.openWindow(CdsUrlResolver.getManageWebResourceUri(item.config, item.context.webresourceid, item.solutionId));
             }
         }},
-        { key: "PluginStep", value: async (item) => await vscode.commands.executeCommand(cs.cds.controls.pluginStep.open, item.context.eventhandler_plugintype._pluginassemblyid_value, item.config, item.context) },
-        { key: "PluginStepImage", value: async (item) => await vscode.commands.executeCommand(cs.cds.controls.pluginStepImage.open, item.context._sdkmessageprocessingstepid_value, item.context, item.config) }
+        { key: "PluginStep", value: async (item) => await vscode.commands.executeCommand(cs.cds.controls.pluginStep.open, item.context.eventhandler_plugintype._pluginassemblyid_value, item.context, item.config, item) },
+        { key: "PluginStepImage", value: async (item) => await vscode.commands.executeCommand(cs.cds.controls.pluginStepImage.open, item.context._sdkmessageprocessingstepid_value, item.context, item.config, item) }
     ])
 
 Defined in src/views/cs.cds.viewContainers.cdsExplorer.ts:111

diff --git a/...extension/api/classes/_views_cs_cds_views_pluginstepeditor_.pluginstepeditor.md b/...extension/api/classes/_views_cs_cds_views_pluginstepeditor_.pluginstepeditor.md
@@ -22,11 +22,13 @@ sidebar_label: "PluginStepEditor"
 
 * [config](_views_cs_cds_views_pluginstepeditor_.pluginstepeditor.md#private-config)
 * [disposables](_views_cs_cds_views_pluginstepeditor_.pluginstepeditor.md#protected-disposables)
+* [edit](_views_cs_cds_views_pluginstepeditor_.pluginstepeditor.md#private-edit)
 * [onDidClose](_views_cs_cds_views_pluginstepeditor_.pluginstepeditor.md#ondidclose)
 * [onDidReceiveMessage](_views_cs_cds_views_pluginstepeditor_.pluginstepeditor.md#ondidreceivemessage)
 * [onReady](_views_cs_cds_views_pluginstepeditor_.pluginstepeditor.md#onready)
 * [options](_views_cs_cds_views_pluginstepeditor_.pluginstepeditor.md#options)
 * [renderer](_views_cs_cds_views_pluginstepeditor_.pluginstepeditor.md#protected-renderer)
+* [treeEntry](_views_cs_cds_views_pluginstepeditor_.pluginstepeditor.md#private-treeentry)
 * [openViews](_views_cs_cds_views_pluginstepeditor_.pluginstepeditor.md#static-openviews)
 
 ### Accessors
@@ -70,7 +72,7 @@ Name | Type |
 
 • **config**: *[Config](../interfaces/_api_cds_webapi_cdswebapi_.cdswebapi.config.md)*
 
-Defined in src/views/cs.cds.views.pluginStepEditor.ts:25
+Defined in src/views/cs.cds.views.pluginStepEditor.ts:26
 
 ___
 
@@ -84,6 +86,14 @@ Defined in src/core/webui/View.ts:91
 
 ___
 
+### `Private` edit
+
+• **edit**: *boolean* = false
+
+Defined in src/views/cs.cds.views.pluginStepEditor.ts:28
+
+___
+
 ###  onDidClose
 
 • **onDidClose**: *Event‹[View](_core_webui_view_.view.md)›* = this._onDidClose.event
@@ -134,6 +144,14 @@ Defined in src/core/webui/View.ts:92
 
 ___
 
+### `Private` treeEntry
+
+• **treeEntry**: *[CdsTreeEntry](_views_cs_cds_viewcontainers_cdsexplorer_.cdstreeentry.md)*
+
+Defined in src/views/cs.cds.views.pluginStepEditor.ts:27
+
+___
+
 ### `Static` openViews
 
 ▪ **openViews**: *object*
@@ -156,7 +174,7 @@ Track the currently panel. Only allow a single panel to exist at a time.
 
 *Overrides [View](_core_webui_view_.view.md).[commands](_core_webui_view_.view.md#commands)*
 
-Defined in src/views/cs.cds.views.pluginStepEditor.ts:42
+Defined in src/views/cs.cds.views.pluginStepEditor.ts:45
 
 **Returns:** *[Dictionary](_core_types_dictionary_.dictionary.md)‹string, Function›*
 
@@ -198,7 +216,7 @@ ___
 
 *Overrides [View](_core_webui_view_.view.md).[construct](_core_webui_view_.view.md#abstract-construct)*
 
-Defined in src/views/cs.cds.views.pluginStepEditor.ts:27
+Defined in src/views/cs.cds.views.pluginStepEditor.ts:30
 
 **Parameters:**
 
@@ -244,7 +262,7 @@ ___
 
 ▸ **retrieveAttributes**(`logicalName`: string): *Promise‹void›*
 
-Defined in src/views/cs.cds.views.pluginStepEditor.ts:49
+Defined in src/views/cs.cds.views.pluginStepEditor.ts:52
 
 **Parameters:**
 
@@ -260,7 +278,7 @@ ___
 
 ▸ **save**(`step`: any): *void*
 
-Defined in src/views/cs.cds.views.pluginStepEditor.ts:57
+Defined in src/views/cs.cds.views.pluginStepEditor.ts:60
 
 **Parameters:**
 
@@ -274,17 +292,18 @@ ___
 
 ###  setInitialState
 
-▸ **setInitialState**(`pluginAssemblyId`: string, `config?`: [Config](../interfaces/_api_cds_webapi_cdswebapi_.cdswebapi.config.md), `step?`: any): *Promise‹void›*
+▸ **setInitialState**(`pluginAssemblyId`: string, `step?`: any, `config?`: [Config](../interfaces/_api_cds_webapi_cdswebapi_.cdswebapi.config.md), `treeEntry?`: [CdsTreeEntry](_views_cs_cds_viewcontainers_cdsexplorer_.cdstreeentry.md)): *Promise‹void›*
 
-Defined in src/views/cs.cds.views.pluginStepEditor.ts:70
+Defined in src/views/cs.cds.views.pluginStepEditor.ts:77
 
 **Parameters:**
 
 Name | Type |
 ------ | ------ |
 `pluginAssemblyId` | string |
-`config?` | [Config](../interfaces/_api_cds_webapi_cdswebapi_.cdswebapi.config.md) |
 `step?` | any |
+`config?` | [Config](../interfaces/_api_cds_webapi_cdswebapi_.cdswebapi.config.md) |
+`treeEntry?` | [CdsTreeEntry](_views_cs_cds_viewcontainers_cdsexplorer_.cdstreeentry.md) |
 
 **Returns:** *Promise‹void›*