add pkg/runtime/resourceconfig.ResourceConfig #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Iceber, DetailsInstructions for interacting with me using comments are available here. |
Iceber
force-pushed
the
change_storage_config
branch
from
200cb60 to
216b049
Compare
Iceber
force-pushed
the
change_storage_config
branch
4 times, most recently
from
c4805da to
6038f09
Compare
Iceber
force-pushed
the
change_storage_config
branch
from
6038f09 to
9e946fe
Compare
Signed-off-by: Iceber Gu <caiwei95@hotmail.com>
Iceber
force-pushed
the
change_storage_config
branch
from
9e946fe to
3e4a62e
Compare
Signed-off-by: Iceber Gu <caiwei95@hotmail.com>
Iceber
force-pushed
the
change_storage_config
branch
from
3e4a62e to
bdd4072
Compare
Iceber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
There are multiple resource and version fields in ResourceStorageConfig that can be easily misinterpreted, so we'll merge them now
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: