-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello Bar Syndication #886
Conversation
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
…esponsiveness, UX Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Looks good. Here are some comments:
Since we've already forked this version of the docsy theme, I think it'd be ok to hack into the way the navbar works, if necessary, so we could get a better implementation of the hello bar that scrolls together as one piece, like the one on the CNCF site. Do you think that's achievable?
|
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
I've addressed 3, 6, and 7. I'd say we could try deploying it to test issue 1? |
2 - Yes there are many options we can introduce. 4 - OK, the sites where the bar is to be used was not clear in the task specification. I was working on the basis of all sub-sites as per the all-CNCF page. If it's just Hugo sites that changes the parameters somewhat. 5 - is that FOUC? The bar is coded to be inserted once it's loaded. I would think that's a layout shift issue, but even animating the height would trigger that I believe. I could add some kind of effect on it (animating the height), strictly speaking we would then need to turn that off depending on a users browser settings for animations. Perhaps with this new information about the cache and Hugo only compatibility requirements this isn't the approach to take. |
To address issue 1 I've started a new PR that keeps the API call in place so that cacheing can be precisely controlled. I've combined it with some of the code from this PR. |
Above script is implemented on Glossary preview site via this PR
Outstanding: