-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pod lifecycle events project #1279
Conversation
I think @sftim @nate-double-u or @divya-mohan0209 can help. |
Hi @SergeyKanzhelev, thanks for this! Since this is a proposal for a Kubernetes project, we'll also need the approval of the sig-contribex leads. Usually, we'd require a project maintainer's approval, but things are a bit different with K8s projects and subprojects. I believe the chairs are currently: @kaslin & @palnabarun, if you could both take a look 🙂 I'd also like to wait for the upstream issue to get triaged before we accept this (I expect this is part of why this is a WIP proposal 🙂). When it comes time, could @tallclair provide a 👍 or approve this PR to confirm participation? |
/assign @tallclair @nate-double-u definitely will contact contribex leads, I was not sure what the process is =). |
Within Kubernetes, we don't require any review @nate-double-u. We confirmed this in slack with a past project lead and our mentoring subproject lead (@jberkus). That said, we're happy to review if folks want us to. |
Looks Good to Me 👍 |
The request is more for the CNCF mentorship admins—usually, we require a maintainer to approve an LFX mentorship proposal before accepting it. In the case of Kubernetes, the project structure is much more complex, so we landed on asking for sig-contribex chairs to play the approver role. It's a way of confirming that the project approves of the work being done (and, by extension, agrees that the money spent would be worthwhile). So, I very much appreciate you doing the reviews! |
/approve |
This is still set to WIP, and I'm still looking for a 👍 or approval from @tallclair to confirm their participation. The PR was opened before the due date, so don't worry about not getting this merged before today. Even if it's a couple days late we can load this into the LFX platform but it may have to go in on the second pass (which means it may miss being available for the first day or 2 of candidate applications). |
847d3a4
to
2ea84a9
Compare
@tallclair is out of office till Monday, but I promise he signed up for this with me. I don't want to expose Tim's email without his confirmation. Would it be ok to keep it as TODO till Monday? |
Monday is OK. |
2ea84a9
to
df95f25
Compare
Sorry for the delay. Yes, Sergey and I discussed this offline. 👍 from me. |
4d1c62f
to
068fb8e
Compare
Signed-off-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
068fb8e
to
b4fe1bf
Compare
@nate-double-u this is ready to be merged |
Signed-off-by: Nate W <natew@cncf.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll load this up today - should be approved by LFX by tomorrow and will be open for applications. Sorry for the delay, i was off yesterday.
xlink: kubernetes/kubernetes#126369
I will try to find out if anybody from SIG Docs can help. I have limited knowledge of hugo and automation possible on website.