Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base: update ipmicomm.patch to install general templates. #73

Merged
merged 1 commit into from
Aug 27, 2024
Merged

base: update ipmicomm.patch to install general templates. #73

merged 1 commit into from
Aug 27, 2024

Conversation

gustavosr8
Copy link
Contributor

No description provided.

henriquesimoes
henriquesimoes requested changes Aug 26, 2024
View reviewed changes
base/ipmicomm.patch Outdated Show resolved Hide resolved
henriquesimoes
henriquesimoes reviewed Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@henriquesimoes henriquesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd take the opportunity and rename it to backport-ipmicomm.patch, since all those have been merged to the pre-release branch.

It seems sensible to add an entry in the change log as well.

ericonr
ericonr approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after following @henriquesimoes 's suggestions.

@ericonr ericonr mentioned this pull request Aug 27, 2024
Merged
@gustavosr8 gustavosr8 force-pushed the ipmicomm-patch branch 2 times, most recently from 5e37ef2 to 6b79f5d Compare August 27, 2024 13:58
@gustavosr8 gustavosr8 merged commit d204dfb into main Aug 27, 2024
2 checks passed
@gustavosr8 gustavosr8 deleted the ipmicomm-patch branch August 27, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericonr ericonr ericonr approved these changes

@henriquesimoes henriquesimoes henriquesimoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gustavosr8 @henriquesimoes @ericonr