ioc: reorder stages to improve portability. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
requested changes
Aug 11, 2023
Dockerfile
Outdated
| ARG BUILD_STAGE_VERSION=v0.2.0 | ||
| ARG BUILD_STAGE_VERSION=latest |
There was a problem hiding this comment.
This change slipped through.
There was a problem hiding this comment.
Oops. Fixed!
henriquesimoes
force-pushed
the
no-buildkit
branch
from
176b8d6
to
f0afe16
Compare
Docker without BuildKit and Podman fail when an unused stage fails before the defined target. As static build stage from the IOC image is known to possibly fail, we now define all static build stages last. Arguments have now been defined only in stages they are used. This is required to support non-BuildKit builds, as they aren't inherited.
ericonr
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker without BuildKit and Podman fail when an unused stage fails before the defined target. As static build stage from the IOC image is known to possibly fail, we now define all static build stages last.
Arguments have now been defined only in stages they are used. This is required to support non-BuildKit builds, as they aren't inherited.