Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate mipmaps for planar reflection #15629

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

xubing0906
Copy link
Contributor

@xubing0906 xubing0906 commented Jul 5, 2023

Re: https://github.com/cocos/3d-tasks/issues/16034

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -12535,8 +12535,9 @@
                  * @zh 反射探针cube模式的预览小球
                  */
                 protected _previewSphere: Node | null;
                 protected _previewPlane: Node | null;
+                protected _planarReflectionTexture: gfx.Texture | null;
                 /**
                  * @en Set probe type,cube or planar.
                  * @zh 设置探针类型,cube或者planar
                  */
@@ -12596,8 +12597,9 @@
                  * @zh 反射探针Planar模式的预览平面
                  */
                 set previewPlane(val: Node);
                 get previewPlane(): Node;
+                get planarMipmapCount(): number;
                 constructor(id: number);
                 initialize(node: Node, cameraNode: Node): void;
                 initBakedTextures(): void;
                 captureCubemap(): void;
@@ -36278,8 +36280,17 @@
             checkEnable(camera: renderer.scene.Camera): boolean;
             render(camera: renderer.scene.Camera, ppl: rendering.BasicPipeline): void;
             slotName(camera: renderer.scene.Camera, index?: number): string;
         }
+        export class ReflectionProbePass extends BasePass {
+            name: string;
+            outputNames: string[];
+            enableInAllEditorCamera: boolean;
+            depthBufferShadingScale: number;
+            slotName(camera: renderer.scene.Camera, index?: number): string;
+            render(camera: renderer.scene.Camera, ppl: rendering.Pipeline): void;
+            buildReflectionProbePass(camera: renderer.scene.Camera, ppl: rendering.Pipeline, probe: renderer.scene.ReflectionProbe, renderWindow: __private._cocos_render_scene_core_render_window__RenderWindow, faceIdx: number): void;
+        }
         export class PostProcessBuilder implements rendering.PipelineBuilder {
             pipelines: Map<string, BasePass[]>;
             constructor();
             init(): void;

@xubing0906
Copy link
Contributor Author

@cocos-robot run test cases

@@ -151,6 +151,7 @@ export class ReflectionProbe extends Component {
this._objFlags ^= CCObject.Flags.IsRotationLocked;
}
if (!this._sourceCamera) {
// eslint-disable-next-line no-console
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use warnID instead

@xubing0906
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

@xubing0906, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL particle-rotation,particle-size,label-cacheMode,label-align,ttf-font
ios FAIL FAIL
android PASS PASS FAIL particle-rotation particle-rotation
mac PASS PASS PASS

@xubing0906 xubing0906 changed the base branch from v3.8.1 to develop August 1, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants