-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate mipmaps for planar reflection #15629
Open
xubing0906
wants to merge
12
commits into
cocos:develop
Choose a base branch
from
xubing0906:v3.8.1-planar-mipmaps
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+238
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -12535,8 +12535,9 @@
* @zh 反射探针cube模式的预览小球
*/
protected _previewSphere: Node | null;
protected _previewPlane: Node | null;
+ protected _planarReflectionTexture: gfx.Texture | null;
/**
* @en Set probe type,cube or planar.
* @zh 设置探针类型,cube或者planar
*/
@@ -12596,8 +12597,9 @@
* @zh 反射探针Planar模式的预览平面
*/
set previewPlane(val: Node);
get previewPlane(): Node;
+ get planarMipmapCount(): number;
constructor(id: number);
initialize(node: Node, cameraNode: Node): void;
initBakedTextures(): void;
captureCubemap(): void;
@@ -36278,8 +36280,17 @@
checkEnable(camera: renderer.scene.Camera): boolean;
render(camera: renderer.scene.Camera, ppl: rendering.BasicPipeline): void;
slotName(camera: renderer.scene.Camera, index?: number): string;
}
+ export class ReflectionProbePass extends BasePass {
+ name: string;
+ outputNames: string[];
+ enableInAllEditorCamera: boolean;
+ depthBufferShadingScale: number;
+ slotName(camera: renderer.scene.Camera, index?: number): string;
+ render(camera: renderer.scene.Camera, ppl: rendering.Pipeline): void;
+ buildReflectionProbePass(camera: renderer.scene.Camera, ppl: rendering.Pipeline, probe: renderer.scene.ReflectionProbe, renderWindow: __private._cocos_render_scene_core_render_window__RenderWindow, faceIdx: number): void;
+ }
export class PostProcessBuilder implements rendering.PipelineBuilder {
pipelines: Map<string, BasePass[]>;
constructor();
init(): void;
|
@cocos-robot run test cases |
yiwenxue
reviewed
Jul 7, 2023
@@ -151,6 +151,7 @@ export class ReflectionProbe extends Component { | |||
this._objFlags ^= CCObject.Flags.IsRotationLocked; | |||
} | |||
if (!this._sourceCamera) { | |||
// eslint-disable-next-line no-console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should use warnID instead
@cocos-robot run test cases |
@xubing0906, Please check the result of
Task Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: https://github.com/cocos/3d-tasks/issues/16034
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: