-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(utils): use cliui as central logger #487
Conversation
06ef194
to
a13b9cd
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fba81fc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 9 targets
Sent with 💌 from NxCloud. |
packages/cli/src/lib/implementation/only-plugins.utils.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/print-config/print-config-command.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/lib/implementation/execute-plugin.unit-test.ts
Outdated
Show resolved
Hide resolved
…st.ts Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
Once the proper matchers are applied in all applicable places, this PR is good to go from my side!
packages/cli/src/lib/print-config/print-config-command.unit.test.ts
Outdated
Show resolved
Hide resolved
…ble-from-cliui # Conflicts: # packages/utils/src/lib/git.integration.test.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌈
This PR includes:
opened Feature: Add list to the ui features poppinss/cliui#14 to get rid of 3table and use
cliui
helpers insteadopened replace issaac/cliui div with cliui helpers #513
issue opened Add flush method to empty the
logs
array in logger poppinss/cliui#15PR opened feat(logger): add flushLogs method to tests poppinss/cliui#16
Note
I will move #513 into a new PR and implement in when the PR in cliui is in if I reopen ever.
created #552
Testing:
I tried to use hooks for the logger tests to switch to
raw
mode and cleanup the logsbeforeEach
run.I was only able to use this setup in
utils
which imports directly the file:Working code:
However in
core
andcli
i was only able to have the mode switching in the setup script and hat to move the logger cleanup in the test files. If I importui
from@code-pushup/utils
many other tests fail.Working reduced script:
Update:
I was able to implement the beforeEach hook with async imports:
closes #502
related #513