Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live chatting feature to communicate between two players #317

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mvp5464
Copy link

@mvp5464 mvp5464 commented May 10, 2024

Created Live chatting feature

chessMessage.webm

@Airbornharsh
Copy link
Contributor

Already Added in PR #198
so you can close it

@mvp5464
Copy link
Author

mvp5464 commented May 11, 2024

Already Added in PR #198 so you can close it

I saw the pr, it is great with many features but I think it would be good if you create different pr for different features. So that it would be easy for sir to review ig and contributor to contribute without conflicts. (just an opinion brother)

@mvp5464
Copy link
Author

mvp5464 commented May 11, 2024

Added red dot for new message notification

notificationDot.webm

@Airbornharsh
Copy link
Contributor

Already Added in PR #198 so you can close it

I saw the pr, it is great with many features but I think it would be good if you create different pr for different features. So that it would be easy for sir to review ig and contributor to contribute without conflicts. (just an opinion brother)

Yeah but All Features are connected

@Airbornharsh
Copy link
Contributor

Added red dot for new message notification

notificationDot.webm

If my PR merged then you can add these swapping feature after that.
As there is Timing for moves also

@mvp5464
Copy link
Author

mvp5464 commented May 12, 2024

Added red dot for new message notification

notificationDot.webm

If my PR merged then you can add these swapping feature after that. As there is Timing for moves also

Okay sure, Pr is ready but creating a draft.

@mvp5464 mvp5464 marked this pull request as draft May 12, 2024 14:28
@mvp5464 mvp5464 marked this pull request as ready for review May 19, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants