Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Dedupe kwargs snake case decorator #924

Merged
merged 2 commits into from
Oct 25, 2024
Merged

chore: Dedupe kwargs snake case decorator #924

merged 2 commits into from
Oct 25, 2024

Conversation

suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Oct 24, 2024

This other PR deprecated the snake case fallback resolver in favor of ariadne's convert_names_case option.

The default object case behavior is deprecated: snake case fallback resolver
Ariadne calls out convert_names_case as the new correct way to convert case names

This PR is a follow-up clean-up to remove the since-duplicated instances of the snake case decorator.

Tested by smoke testing on staging and confirming no regression in these graphql queries

Closes codecov/engineering-team#1879
Closes codecov/engineering-team#2757 (duplicate)

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (1279697) to head (4d2a1e5).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
- Coverage   96.24%   96.23%   -0.01%     
==========================================
  Files         823      823              
  Lines       18992    18953      -39     
==========================================
- Hits        18279    18240      -39     
  Misses        713      713              
Flag Coverage Δ
unit 92.47% <100.00%> (-0.02%) ⬇️
unit-latest-uploader 92.47% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@suejung-sentry suejung-sentry marked this pull request as ready for review October 25, 2024 16:53
@suejung-sentry suejung-sentry requested a review from a team as a code owner October 25, 2024 16:53
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@suejung-sentry
Copy link
Contributor Author

smoke test staging qa screenshots
bundle analysis
Screenshot 2024-10-25 at 12 25 35 PM

impacted files
Screenshot 2024-10-25 at 12 42 17 PM

segments
Screenshot 2024-10-25 at 12 44 05 PM

coverageInfo
Screenshot 2024-10-25 at 12 45 10 PM

pretrial plan
Screenshot 2024-10-25 at 12 50 39 PM

available plans
Screenshot 2024-10-25 at 12 54 22 PM

plan trial, etc. fields; plan_representation fields
Screenshot 2024-10-25 at 12 58 14 PM

repo pulls, branches, commits
Screenshot 2024-10-25 at 1 01 00 PM
Screenshot 2024-10-25 at 1 01 51 PM
Screenshot 2024-10-25 at 1 02 21 PM

mutations - did the operation for regenerate_repository_token to confirm that still works as expected

@suejung-sentry suejung-sentry added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit c5b5a8f Oct 25, 2024
30 of 32 checks passed
@suejung-sentry suejung-sentry deleted the sshin/2757 branch October 25, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove instances of @kwargs_to_snake_case decorator Remove @convert_kwargs_to_snake_case Decorator
2 participants