fix: get_results returns none if table is empty #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously we were returning a table that had a bunch of null columns this is actually due to us not having a strict schema on the worker side but a good fix here anyways is to return None from get_results when there's no data in the table
joseph-sentry
force-pushed
the
joseph/fix-gql-bug
branch
from
53be0f6
to
e3cb633
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
==========================================
- Coverage 96.03% 96.03% -0.01%
==========================================
Files 827 827
Lines 19071 19073 +2
==========================================
+ Hits 18315 18316 +1
- Misses 756 757 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
ajay-sentry
approved these changes
Nov 12, 2024
joseph-sentry
temporarily deployed
to
staging
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously we were returning a table that had a bunch of null columns
this is actually due to us not having a strict schema on the worker side
but a good fix here anyways is to return None from get_results when
there's no data in the table