-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
223 heatload graph #288
Open
derekvmcintire
wants to merge
16
commits into
codeforboston:main
Choose a base branch
from
derekvmcintire:223_heatload_graph
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
223 heatload graph #288
derekvmcintire
wants to merge
16
commits into
codeforboston:main
from
derekvmcintire:223_heatload_graph
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questions to answer:
lastResult
has anaverage_heat_load
that is higher than themaximum_heat_load
, which causes the average point and line to be above the maximum. Is there a better data set that I should be using, or am I misunderstanding the data? In general, am I using the correct data here? And are my calculations correct? They are based off of the document in the issue comments, but the console.log listed in the issue was logging thebalance_point_graph
records, which I am not using.Work Done
Using the JSON data in
lastResult
, I did the following:HeatLoadAnalysis
component (routes/_heat+/heatloadanalysis.tsx
)components/ui.../HeatLoadAnalysis.tsx
)HeatLoad
component for displayTesting
Notes
Graphs
component for now. We could create a context to share this data or at least avoid prop drilling here.Observations
routes.../heatloadanalysis.tsx
andcomponents.../HeatLoadAnalysis.tsx
are meant to compliment each other.Screenshots:
Desktop View:
Tool tip:
Mobile View: