Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Llm bill summary #1645

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

mertbagt
Copy link
Collaborator

@mertbagt mertbagt commented Nov 13, 2024

Summary

issue #1606 Add Bill Summary + Tags to Bill Details Page

implemented Bill Summary and Smart Tags

Checklist

  • On the frontend, I've made my strings translate-able.
  • [n/a ] If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

image

mobile:

light bulb icon removed in mobile per M. Victor

image

bill that has neither bill.summary nor bill.topics:

image

Known issues

icon

in order to detirmine the proper smart tag icon, it would be very helpful to change the Bill object:

  1. change key: topics to subtopics
  2. add key: topic and populate them according to https://docs.google.com/spreadsheets/d/1rPwg52g_oJF_c64kkZDlpWqUbT5MBkh1/edit?pli=1&gid=139906182#gid=139906182

Example:

Bill:
topic: (1) "Commerce"
subtopics: (3) [Consumer Protection, Marketing and advertising, Securities]

this will allow checking against a much smaller and more importantly a less change prone list that will result in less maintenence over the long haul

Steps to test/reproduce

  1. Navigate to bill H5068
  2. View bill with both desktop and mobile sizing
  3. Navigate to some other bill
  4. insure it displays correctly when a bill has neither a summary or topics

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 4:16pm

@mertbagt mertbagt marked this pull request as draft November 13, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant